-
-
Notifications
You must be signed in to change notification settings - Fork 934
Open
Labels
Description
Summary
It would be nice to support jekyll-commonmark 1.4, even if that won't change a thing right now.
alembic/alembic-jekyll-theme.gemspec
Line 25 in 4e6f906
| spec.add_runtime_dependency "jekyll-commonmark", "~> 1.3.1" |
But it will be important to track when jekyll-commonmark 1.5 or 2.0 is released to bring support for ruby 4.0.
jekyll-commonmark 1.3 or 1.4 requires commonmarker 0.22 or 0.23 which depends on Ruby >= 2.6, < 4.0, prevent ruby 4.0 support.
So jekyll-commonmark needs to support commonmarker 2.6.1+, and then alembic would have to support jekyll-commonmark new release.
To Reproduce
Have this in a Gemfile under Ruby 4.0.0 and run bundle install.
gem 'alembic-jekyll-theme', '~> 4.1' # jekyll theme
gem 'jekyll', '~> 4.4', '>= 4.4.1' # user documentation
gem 'jekyll-commonmark', '~> 1.3' # jekyll markdown plugin
gem 'jekyll-default-layout', '~> 0.1.5' # jekyll plugin that set default layout automatically
gem 'jekyll-optional-front-matter', '~> 0.3.2' # jekyll plugin so that YAML frontmatter are optionnals
gem 'jekyll-readme-index', '~> 0.3.0' # jekyll plugin so that README.md becomes the index
gem 'jekyll-seo-tag', '~> 2.6' # jekyll seo pluginExpected behaviour
Support for ruby 4.0
Environment
- Ruby version: 4.0.0
- Jekyll version: 4.4.1
- Theme version: 4.1.0