fix: padding.left and padding.right are now supported in PDF/LaTeX

Author: davidgohel

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: flextable
 Title: Functions for Tabular Reporting
-Version: 0.9.11
+Version: 0.9.12.001
 Authors@R: c(
     person("David", "Gohel", , "david.gohel@ardata.fr", role = c("aut", "cre")),
     person("ArData", role = "cph"),

NEWS.md

@@ -1,3 +1,10 @@
+# flextable 0.9.12
+
+## issues
+
+- `padding.left` and `padding.right` are now supported in PDF/LaTeX output.
+
+
 # flextable 0.9.11
 
 ## new features

R/latex_str.R

@@ -128,10 +128,22 @@ gen_raw_latex <- function(x, lat_container = latex_container_none(),
   # latex for multirow ----
   augment_multirow_fixed(cell_properties_df)
 
+  # paragraph padding ----
+  cell_properties_df[, c("padding_left_str", "padding_right_str") := list(
+    ifelse(.SD$padding.left > 0,
+           sprintf("\\advance\\leftskip by %.1fpt\\relax ", .SD$padding.left),
+           ""),
+    ifelse(.SD$padding.right > 0,
+           sprintf("\\advance\\rightskip by %.1fpt\\relax ", .SD$padding.right),
+           "")
+  )]
+
   # paste everything ----
   cell_properties_df[, c("txt") := list(
     paste0(
       .SD$multirow_left,
+      .SD$padding_left_str,
+      .SD$padding_right_str,
       .SD$text_direction_left,
       .SD$txt,
       .SD$text_direction_right,

R/printers.R

@@ -581,8 +581,8 @@ print.flextable <- function(x, preview = "html", align = "center", ...) {
 #' @section PDF limitations:
 #'
 #' The following properties are not supported in PDF output:
-#' padding, `line_spacing` and row `height`. Justified text is
-#' converted to left-aligned.
+#' `padding.top`, `padding.bottom`, `line_spacing` and row `height`.
+#' Justified text is converted to left-aligned.
 #'
 #' To use system fonts, set `latex_engine: xelatex` in the YAML
 #' header (the default `pdflatex` engine does not support them).

R/styles.R

@@ -578,8 +578,10 @@ font <- function(
 #' @title Set paragraph paddings
 #' @description Change the padding of selected rows and columns of a flextable.
 #' @note
-#' Padding is not implemented in PDF due to technical infeasibility but
-#' it can be replaced with `set_table_properties(opts_pdf = list(tabcolsep = 1))`.
+#' In PDF output, only `padding.left` and `padding.right` are supported.
+#' `padding.top` and `padding.bottom` are ignored due to LaTeX limitations.
+#' Global horizontal spacing can also be set with
+#' `set_table_properties(opts_pdf = list(tabcolsep = 1))`.
 #' @inheritParams args_selectors_with_all
 #' @param padding padding (shortcut for top, bottom, left and right), unit is pts (points).
 #' @param padding.top padding top, unit is pts (points).

man/knit_print.flextable.Rd

@@ -339,3 +339,27 @@ test_that("font warning fires for Quarto + pdflatex", {
 
   knitr::opts_knit$set("quarto.version" = NULL, "out.format" = NULL)
 })
+
+test_that("padding.left and padding.right produce advance leftskip/rightskip in latex", {
+  ft <- flextable(data.frame(a = c("hello", "world"), b = 1:2))
+  ft <- padding(ft, padding.left = 0, padding.right = 0, part = "all")
+  ft <- padding(ft, i = 1, j = 1, padding.left = 20)
+  ft <- padding(ft, i = 2, j = 1, padding.right = 15)
+  latex_str <- flextable:::gen_raw_latex(ft)
+
+  # row 1 col 1: \advance\leftskip by 20.0pt\relax
+  expect_match(latex_str, "\\advance\\leftskip by 20.0pt\\relax", fixed = TRUE)
+
+  # row 2 col 1: \advance\rightskip by 15.0pt\relax
+  expect_match(latex_str, "\\advance\\rightskip by 15.0pt\\relax", fixed = TRUE)
+
+  # only 1 leftskip and 1 rightskip (other cells have padding = 0)
+  expect_equal(
+    length(gregexpr("advance\\\\leftskip", latex_str, perl = TRUE)[[1]]),
+    1L
+  )
+  expect_equal(
+    length(gregexpr("advance\\\\rightskip", latex_str, perl = TRUE)[[1]]),
+    1L
+  )
+})