Skip to content

Commit 9a4e4eb

Browse files
committed
change: reorder arguments of girafe() with argument ggobj in first position
see #327
1 parent d28ce9b commit 9a4e4eb

File tree

6 files changed

+15
-7
lines changed

6 files changed

+15
-7
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Type: Package
22
Package: ggiraph
33
Title: Make 'ggplot2' Graphics Interactive
4-
Version: 0.9.2
4+
Version: 0.9.3.001
55
Authors@R: c(
66
person("David", "Gohel", , "david.gohel@ardata.fr", role = c("aut", "cre")),
77
person("Panagiotis", "Skintzos", , "sigmapi@posteo.net", role = "aut"),

NEWS.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
# ggiraph 0.9.3
2+
3+
## Change
4+
5+
- reorder arguments of `girafe()` with argument `ggobj` in first position.
6+
IT DOES NOT makes ggplot objects pipe-able with `girafe()` (unless you add
7+
parenthesis around your ggplot code).
8+
19
# ggiraph 0.9.2
210

311
## Feature

R/girafe.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@
9494
#' @seealso [girafe_options()], [validated_fonts()], [dsvg()]
9595
#' @export
9696
girafe <- function(
97-
code,
9897
ggobj = NULL,
98+
code,
9999
pointsize = 12,
100100
width_svg = NULL,
101101
height_svg = NULL,

inst/tinytest/test-girafe_options.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ library(ggiraph)
267267
# girafe_options ----
268268
{
269269
expect_error(girafe_options("foo"), info = "check x argument")
270-
g <- girafe({
270+
g <- girafe(code = {
271271
NULL
272272
})
273273
expect_identical(girafe_options(g), g, info = "no options set")

inst/tinytest/test-trailing-comma.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ library(ggplot2)
4141

4242
# girafe_options, trailing comma ----
4343
{
44-
g <- girafe({
44+
g <- girafe(code = {
4545
NULL
4646
})
4747
expect_identical(girafe_options(g, ), g, info = "no options set")

man/girafe.Rd

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)