[BUG] - user.videos() count is ignored

[stolenvw]

I have not updated in awhile, last version i was on was 6.2.2 updated to 7.2.1 and now count is ignored in async for video in user.videos(count=1)

Looking through the comments it looks like in version 6.4.0 count got hard coded to 35.

[velenciucsergiu]

+1

[mimo-om]

The count should be hard coded here as this is the request param which are send to Tiktok API if you will change this count the Tiktok will know that you are a bot and return an empty response, The count you are requesting is used in found < count to loop in the request with appropriate cursor values until you get the found >= count you break the loop

[stolenvw]

that while loop does not stop it when you use a count under 20

for video in resp.get("itemList", []):
                yield self.parent.video(data=video)
                found += 1

is inside that while loop so if you do a async for video in user.videos(count=1) you will get the 20 results not the 1 your looking for because of the hard code getting 20

>>> async def t():
...     async with TikTokApi() as api:
...         await api.create_sessions(ms_tokens=[ms_token], num_sessions=5, sleep_after=3, headless=True, browser="firefox")
...         async for video in api.user("<removed>").videos(count=1):
...             print(video)
...             
>>> asyncio.run(t())
TikTokApi.video(id='7546710747556875551')
TikTokApi.video(id='7546707960253189406')
TikTokApi.video(id='7546706468741860638')
TikTokApi.video(id='7546706190202326302')
TikTokApi.video(id='7546704848469691678')
TikTokApi.video(id='7546704127703797023')
TikTokApi.video(id='7546702141272902943')
TikTokApi.video(id='7546697765825334559')
TikTokApi.video(id='7532855705951374622')
TikTokApi.video(id='7532533117819620638')
TikTokApi.video(id='7529351876215590174')
TikTokApi.video(id='7507363569760062751')
TikTokApi.video(id='7463028358746492191')
TikTokApi.video(id='7449727177177746718')
TikTokApi.video(id='7420889795087306027')
TikTokApi.video(id='7420505627631422751')
TikTokApi.video(id='7395609028140797226')

[stolenvw]

after setting the hard code to "count": min(count, 20),

>>> async def t():
...     async with TikTokApi() as api:
...         await api.create_sessions(ms_tokens=[ms_token], num_sessions=5, sleep_after=3, headless=True, browser="firefox")
...         async for video in api.user("<removed>").videos(count=1):
...             print(video)
...             
>>> asyncio.run(t())
TikTokApi.video(id='7546710747556875551')
>>> 

you get the amount you want, i have been running my bot for 2 weeks with it changed locally with no issues at all

[mimo-om]

I see you want the count to be under 20 ok that works as will.

[stolenvw]

I see you want the count to be under 20 ok that works as will.

yup thats what the min(count, 20) does if its under 20 it gets the count if count is over 20 it only gets 20 at a time and will run the while loop and use the cursor to get more

its still flawed and should prob be something like like min((count - found), 20) so if count is set to 30 it gets 20 first loop and 10 next loop instead of 20 each run of the loop and returning 40 instead of the 30 that was asked for. but that will run it to problems if loop runs more then 2 times, so wont really work

[mimo-om]

agreed can add that to my PR.

[stolenvw]

looking at this some more a "count": min((count - found), 20), should actually work even if you did a async for video in api.user("user").videos(count=70): the count variable doesn't get updated in the loop so it shouldn't end up being a negative number.