Skip to content

Commit 5bdf993

Browse files
davidwendtclaude
andcommitted
Remove minhash invalid UTF-8 test
Results for invalid UTF-8 input are undefined. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent a5d1f7b commit 5bdf993

1 file changed

Lines changed: 0 additions & 21 deletions

File tree

‎cpp/tests/text/minhash_tests.cpp‎

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -339,27 +339,6 @@ TEST_F(MinHashTest, PermutedParameterChunks)
339339
verify_parameter_slices<uint64_t>(view, 5000, mh64);
340340
}
341341

342-
TEST_F(MinHashTest, InvalidUTF8)
343-
{
344-
// results for invalid UTF-8 are undefined but should not cause out-of-bounds reads
345-
auto input = cudf::test::strings_column_wrapper({"a" + std::string(6000, '\x80') + "bc",
346-
std::string(3000, '\xbf'),
347-
"x" + std::string(40000, '\x80')});
348-
auto view = cudf::strings_column_view(input);
349-
350-
auto first = cuda::counting_iterator<uint32_t>{10};
351-
auto params = cudf::test::fixed_width_column_wrapper<uint32_t>(first, first + 3);
352-
auto params64 = cudf::test::fixed_width_column_wrapper<uint64_t, uint32_t>(first, first + 3);
353-
for (auto width : {4, 1100}) {
354-
auto results =
355-
nvtext::minhash(view, 0, cudf::column_view(params), cudf::column_view(params), width);
356-
EXPECT_EQ(results->size(), view.size());
357-
auto results64 =
358-
nvtext::minhash64(view, 0, cudf::column_view(params64), cudf::column_view(params64), width);
359-
EXPECT_EQ(results64->size(), view.size());
360-
}
361-
}
362-
363342
TEST_F(MinHashTest, EmptyTest)
364343
{
365344
auto input = cudf::make_empty_column(cudf::data_type{cudf::type_id::STRING});

0 commit comments

Comments
 (0)