MQTTPubSub is not compatible with PubSubEngine type definitions

[MichaelHindley]

Trying to use MQTTPubSub with TypeScript results in this compilation error.

graphql-mqtt-subscriptions: 1.1.0
typescript: 3.1

[Victordmdb]

Getting a similar issue but instead with MQTT lib.

  error TS2322: Type 'import("PATH/node_modules/mqtt/types/lib/client").MqttClient' is not assignable to type 'import("PATH/node_modules/graphql-mqtt-subscriptions/node_modules/mqtt/types/lib/client").MqttClient'.
  Types of property 'options' are incompatible.
    Type 'import("PATH/node_modules/mqtt/types/lib/client-options").IClientOptions' is not assignable to type 'import("PATH/node_modules/graphql-mqtt-subscriptions/node_modules/mqtt/types/lib/client-options").IClientOptions'.
      Types of property 'transformWsUrl' are incompatible.
        Type '(url: string, options: import("PATH/node_modules/mqtt/types/lib/client-options").IClientOptions, client: import("PATH/node_modules/mqtt/types/lib/client").MqttClient) => string' is not assignable to type '(url: string, options: import("PATH/node_modules/graphql-mqtt-subscriptions/node_modules/mqtt/types/lib/client-options").IClientOptions, client: import("PATH/node_modules/graphql-mqtt-subscriptions/node_modules/mqtt/types/lib/client").MqttClient) => string'.
          Types of parameters 'client' and 'client' are incompatible.
            Type 'import("PATH/node_modules/graphql-mqtt-subscriptions/node_modules/mqtt/types/lib/client").MqttClient' is not assignable to type 'import("PATH/node_modules/mqtt/types/lib/client").MqttClient'.
              Types of property 'subscribe' are incompatible.
                Type '{ (topic: string | string[], opts: import("PATH/node_modules/graphql-mqtt-subscriptions/node_modules/mqtt/types/lib/client-options").IClientSubscribeOptions, callback?: import("PATH/node_modules/graphql-mqtt-subscriptions/node_modules/mqtt/types/lib/client").ClientSubs...' is not assignable to type '{ (topic: string | string[], opts: import("PATH/node_modules/mqtt/types/lib/client-options").IClientSubscribeOptions, callback?: import("PATH/node_modules/mqtt/types/lib/client").ClientSubscribeCallback): import("PATH/node_modules/mqtt/types/lib...'.
                  Types of parameters 'opts' and 'callback' are incompatible.
                    Property 'qos' is missing in type 'ClientSubscribeCallback' but required in type 'IClientSubscribeOptions'.

21 export default new MQTTPubSub({ client });
                                   ~~~~~~

  node_modules/graphql-mqtt-subscriptions/node_modules/mqtt/types/lib/client-options.d.ts:112:3
    112   qos: QoS
          ~~~
    'qos' is declared here.
  node_modules/graphql-mqtt-subscriptions/node_modules/mqtt/types/lib/client-options.d.ts:126:3
    126   qos: QoS
          ~~~
    'qos' is declared here.
  node_modules/graphql-mqtt-subscriptions/dist/mqtt-pubsub.d.ts:5:5
    5     client?: Client;
          ~~~~~~
    The expected type comes from property 'client' which is declared here on type 'PubSubMQTTOptions'

[wtrocki]

See https://github.com/aerogear/graphql-mqtt-subscriptions

We have that done.

@davidyaha Our team is maintaining the fork of the library. Would you consider merging the changes from our fork or putting note in the repo.

[wtrocki]

Genrally it will be hard to merge due to extensive changes that happened. We tried to pull out whatever was easy to integrate but not all things are possible.