[Lens as code] unify legend schemas (elastic#260034)

## Summary

Close elastic#258612

- unifies legend visibility schemas:
elastic@ee1a916
- removes `position` from the API schema for heatmaps
elastic@7ec24f8
- unifies legend size
elastic@d190721

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Author: drewdaemon

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/heatmap.ts

@@ -22,19 +22,18 @@ import {
   legendTruncateAfterLinesSchema,
 } from '../shared';
 import {
+  baseLegendVisibilitySchema,
   legendSizeSchema,
   mergeAllMetricsWithChartDimensionSchemaWithRefBasedOps,
   xScaleSchema,
 } from './shared';
-import { positionSchema } from '../alignments';
 import { builderEnums } from '../enums';
 import { bucketOperationDefinitionSchema } from '../bucket_ops';
 
 const legendSchemaProps = {
   truncate_after_lines: legendTruncateAfterLinesSchema,
-  visible: schema.maybe(schema.boolean({ meta: { description: 'Show the legend' } })),
+  visibility: baseLegendVisibilitySchema,
   size: legendSizeSchema,
-  position: schema.maybe(positionSchema({ meta: { description: 'Legend position' } })),
 };
 
 const labelsSchemaProps = {

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/mosaic.ts

@@ -19,9 +19,10 @@ import {
   legendTruncateAfterLinesSchema,
   sharedPanelInfoSchema,
 } from '../shared';
-import { legendNestedSchema, legendVisibilitySchema, valueDisplaySchema } from './partition_shared';
+import { legendNestedSchema, valueDisplaySchema } from './partition_shared';
 import {
   legendSizeSchema,
+  legendVisibilitySchemaWithAuto,
   mergeAllBucketsWithChartDimensionSchema,
   mergeAllMetricsWithChartDimensionSchemaWithRefBasedOps,
 } from './shared';
@@ -33,7 +34,7 @@ const mosaicStateSharedSchema = {
       {
         nested: legendNestedSchema,
         truncate_after_lines: legendTruncateAfterLinesSchema,
-        visibility: legendVisibilitySchema,
+        visibility: legendVisibilitySchemaWithAuto,
         size: legendSizeSchema,
       },
       {

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/partition_shared.ts

@@ -11,12 +11,6 @@ import { schema } from '@kbn/config-schema';
 import type { ColorMappingType, StaticColorType } from '../color';
 import { groupIsNotCollapsed } from '../../utils';
 
-export const legendVisibilitySchema = schema.maybe(
-  schema.oneOf([schema.literal('auto'), schema.literal('visible'), schema.literal('hidden')], {
-    meta: { description: 'Legend visibility' },
-  })
-);
-
 export const valueDisplaySchema = schema.maybe(
   schema.object(
     {

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/pie.ts

@@ -21,13 +21,13 @@ import {
 } from '../shared';
 import {
   legendSizeSchema,
+  legendVisibilitySchemaWithAuto,
   mergeAllBucketsWithChartDimensionSchema,
   mergeAllMetricsWithChartDimensionSchemaWithRefBasedOps,
 } from './shared';
 import type { PartitionMetric } from './partition_shared';
 import {
   legendNestedSchema,
-  legendVisibilitySchema,
   validateColoringAssignments,
   valueDisplaySchema,
 } from './partition_shared';
@@ -42,7 +42,7 @@ const pieStateSharedSchema = {
       {
         nested: legendNestedSchema,
         truncate_after_lines: legendTruncateAfterLinesSchema,
-        visibility: legendVisibilitySchema,
+        visibility: legendVisibilitySchemaWithAuto,
         size: legendSizeSchema,
       },
       {

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/shared.ts

@@ -32,6 +32,18 @@ import {
   bucketFiltersOperationSchema,
 } from '../bucket_ops';
 
+export const baseLegendVisibilitySchema = schema.maybe(
+  schema.oneOf([schema.literal('visible'), schema.literal('hidden')], {
+    meta: { description: 'Legend visibility' },
+  })
+);
+
+export const legendVisibilitySchemaWithAuto = schema.maybe(
+  schema.oneOf([schema.literal('auto'), schema.literal('visible'), schema.literal('hidden')], {
+    meta: { description: 'Legend visibility' },
+  })
+);
+
 export const legendSizeSchema = schema.maybe(
   schema.oneOf(
     [

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/treemap.ts

@@ -23,12 +23,12 @@ import {
 import type { PartitionMetric } from './partition_shared';
 import {
   legendNestedSchema,
-  legendVisibilitySchema,
   validateColoringAssignments,
   valueDisplaySchema,
 } from './partition_shared';
 import {
   legendSizeSchema,
+  legendVisibilitySchemaWithAuto,
   mergeAllBucketsWithChartDimensionSchema,
   mergeAllMetricsWithChartDimensionSchemaWithRefBasedOps,
 } from './shared';
@@ -40,7 +40,7 @@ const treemapSharedStateSchema = {
       {
         nested: legendNestedSchema,
         truncate_after_lines: legendTruncateAfterLinesSchema,
-        visibility: legendVisibilitySchema,
+        visibility: legendVisibilitySchemaWithAuto,
         size: legendSizeSchema,
       },
       {

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/waffle.ts

@@ -19,13 +19,10 @@ import {
   sharedPanelInfoSchema,
   legendTruncateAfterLinesSchema,
 } from '../shared';
-import {
-  legendVisibilitySchema,
-  validateMultipleMetricsCriteria,
-  valueDisplaySchema,
-} from './partition_shared';
+import { validateMultipleMetricsCriteria, valueDisplaySchema } from './partition_shared';
 import {
   legendSizeSchema,
+  legendVisibilitySchemaWithAuto,
   mergeAllBucketsWithChartDimensionSchema,
   mergeAllMetricsWithChartDimensionSchemaWithRefBasedOps,
 } from './shared';
@@ -49,7 +46,7 @@ export const waffleStateSharedSchema = {
           )
         ),
         truncate_after_lines: legendTruncateAfterLinesSchema,
-        visibility: legendVisibilitySchema,
+        visibility: legendVisibilitySchemaWithAuto,
         size: legendSizeSchema,
       },
       {

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/xy.ts

@@ -21,6 +21,7 @@ import {
 import { datasetEsqlTableSchema, datasetSchema } from '../dataset';
 import {
   legendSizeSchema,
+  legendVisibilitySchemaWithAuto,
   mergeAllBucketsWithChartDimensionSchema,
   mergeAllMetricsWithChartDimensionSchemaWithRefBasedOps,
   mergeAllMetricsWithChartDimensionSchemaWithStaticOps,
@@ -190,10 +191,7 @@ const xyDataLayerSharedSchema = {
  * Common legend configuration properties for positioning and statistics
  */
 const sharedLegendSchema = {
-  visibility: schema.oneOf(
-    [schema.literal('auto'), schema.literal('visible'), schema.literal('hidden')],
-    { meta: { description: 'Show the legend' } }
-  ),
+  visibility: legendVisibilitySchemaWithAuto,
   statistics: schema.maybe(
     schema.arrayOf(statisticsSchema, {
       meta: { description: 'Statistics to display in legend' },

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/transforms/charts/heatmap/from_api.ts

@@ -74,9 +74,9 @@ function buildVisualizationState(config: HeatmapState): HeatmapVisualizationStat
       }),
     },
     legend: {
-      isVisible: layer.legend?.visible ?? true,
-      position: layer.legend?.position ?? 'right',
+      isVisible: layer.legend?.visibility !== 'hidden',
       type: 'heatmap_legend',
+      position: 'right',
       ...stripUndefined<HeatmapLegendConfigResult>({
         maxLines: layer.legend?.truncate_after_lines,
         legendSize: legendSizeCompat.toState(layer.legend?.size),
@@ -140,8 +140,7 @@ type HeatmapAttributesWithoutFiltersAndQuery = Omit<HeatmapAttributes, 'state'>
 };
 
 export function fromAPItoLensState(config: HeatmapState): HeatmapAttributesWithoutFiltersAndQuery {
-  const _buildDataLayer = (cfg: unknown, i: number) =>
-    buildFormBasedLayer(cfg as HeatmapStateNoESQL);
+  const _buildDataLayer = (cfg: unknown) => buildFormBasedLayer(cfg as HeatmapStateNoESQL);
 
   const { layers, usedDataviews } = buildDatasourceStates(config, _buildDataLayer, getValueColumns);
 

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/transforms/charts/heatmap/to_api.ts

@@ -42,8 +42,7 @@ import { axisLabelOrientationCompat } from '../common';
 
 function getLegendProps(legend: HeatmapVisualizationState['legend']): HeatmapState['legend'] {
   return {
-    visible: legend.isVisible,
-    position: legend.position,
+    visibility: legend.isVisible ? 'visible' : 'hidden',
     ...stripUndefined<HeatmapState['legend']>({
       truncate_after_lines: getLegendTruncateAfterLines(legend),
       size: legendSizeCompat.toAPI(legend.legendSize),