[Fleet] Support global data tags for agentless (elastic#263522)

Author: nchaulet

oas_docs/output/kibana.serverless.yaml

@@ -68,6 +68,9 @@ export interface SimplifiedPackagePolicy {
   supports_agentless?: boolean | null;
   supports_cloud_connector?: boolean | null;
   additional_datastreams_permissions?: string[] | null;
+  // Only available for agentless integration policies.
+  // On standard package policies this field is rejected by server-side validation.
+  global_data_tags?: Array<{ name: string; value: string | number }> | null;
 }
 
 export interface FormattedPackagePolicy extends Omit<PackagePolicy, 'inputs' | 'vars'> {
@@ -195,6 +198,7 @@ export function simplifiedPackagePolicytoNewPackagePolicy(
     supports_cloud_connector: supportsCloudConnector,
     cloud_connector_id: cloudConnectorId,
     additional_datastreams_permissions: additionalDatastreamsPermissions,
+    global_data_tags: globalDataTags,
   } = data;
   const packagePolicy = {
     ...packageToPackagePolicy(
@@ -216,6 +220,10 @@ export function simplifiedPackagePolicytoNewPackagePolicy(
     packagePolicy.additional_datastreams_permissions = additionalDatastreamsPermissions;
   }
 
+  if (globalDataTags) {
+    packagePolicy.global_data_tags = globalDataTags;
+  }
+
   if (packagePolicy.package && options?.experimental_data_stream_features) {
     packagePolicy.package.experimental_data_stream_features =
       options.experimental_data_stream_features;

oas_docs/output/kibana.yaml

@@ -7,6 +7,7 @@
 
 import type { RegistryRelease, ExperimentalDataStreamFeature, DeprecationInfo } from './epm';
 import type { SecretReference } from './secret';
+import type { GlobalDataTag } from './agent_policy';
 
 export interface PackagePolicyPackage {
   name: string;
@@ -109,6 +110,7 @@ export interface NewPackagePolicy {
   supports_agentless?: boolean | null;
   supports_cloud_connector?: boolean | null;
   additional_datastreams_permissions?: string[];
+  global_data_tags?: GlobalDataTag[];
 }
 
 export interface UpdatePackagePolicy extends NewPackagePolicy {

packages/kbn-babel-preset/styled_components_files.js

@@ -265,6 +265,24 @@ export const PackagePolicyBaseSchema = {
     ])
   ),
   package_agent_version_condition: schema.maybe(schema.string()),
+  // Only available for agentless integration policies.
+  // On standard package policies this field is rejected by server-side validation.
+  global_data_tags: schema.maybe(
+    schema.oneOf([
+      schema.literal(null),
+      schema.arrayOf(
+        schema.object({
+          name: schema.string({
+            meta: { description: 'The name of the custom field. Cannot contain spaces.' },
+          }),
+          value: schema.oneOf([schema.string(), schema.number()], {
+            meta: { description: 'The value of the custom field.' },
+          }),
+        }),
+        { maxSize: 100 }
+      ),
+    ])
+  ),
 };
 
 export const NewPackagePolicySchema = schema.object({
@@ -284,6 +302,20 @@ export const PackagePolicySchemaV22 = NewPackagePolicySchema.extends(
     enabled: schema.maybe(schema.boolean()),
     inputs: schema.maybe(schema.arrayOf(schema.any(), { maxSize: 1000 })),
     package: schema.maybe(schema.any()),
+    global_data_tags: undefined,
+  },
+  { unknowns: 'ignore' }
+);
+
+/**
+ * Snapshot of the package policy SO schema as of model version 10.23.0.
+ * Permissive on enabled, inputs, and package so the SO layer can store
+ * internal shapes (e.g. compiled_input, minimal fixtures). If NewPackagePolicySchema
+ * gains new fields, create PackagePolicySchemaV{next} that extends this one.
+ */
+export const PackagePolicySchemaV23 = PackagePolicySchemaV22.extends(
+  {
+    global_data_tags: NewPackagePolicySchema.getPropSchemas().global_data_tags,
   },
   { unknowns: 'ignore' }
 );

x-pack/platform/plugins/shared/fleet/common/services/simplified_package_policy_helper.ts

@@ -35,6 +35,23 @@ export const CreateAgentlessPolicyRequestSchema = {
         },
       })
     ),
+    // Only available for agentless integration policies.
+    // On standard package policies this field is rejected by server-side validation.
+    global_data_tags: schema.maybe(
+      schema.arrayOf(
+        schema.object({
+          name: schema.string({
+            meta: { description: 'The name of the custom field. Cannot contain spaces.' },
+          }),
+          value: schema.oneOf([schema.string(), schema.number()], {
+            meta: { description: 'The value of the custom field.' },
+          }),
+        }),
+        {
+          maxSize: 100,
+        }
+      )
+    ),
     // Cloud connector configuration - all connector settings go here
     cloud_connector: schema.maybe(
       schema.object({

x-pack/platform/plugins/shared/fleet/common/types/models/package_policy.ts

@@ -8,28 +8,28 @@
 import React from 'react';
 import type { RenderResult } from '@testing-library/react';
 
-import type { TestRenderer } from '../../../../../../../mock';
-import { createFleetTestRendererMock } from '../../../../../../../mock';
+import type { TestRenderer } from '../../../../mock';
+import { createFleetTestRendererMock } from '../../../../mock';
 
-import type { NewAgentPolicy, AgentPolicy, PackagePolicyInput } from '../../../../../types';
+import type { NewAgentPolicy, AgentPolicy, PackagePolicyInput } from '../../types';
 
-import { GLOBAL_DATA_TAG_EXCLUDED_INPUTS } from '../../../../../../../../common/constants';
+import { GLOBAL_DATA_TAG_EXCLUDED_INPUTS } from '../../../../../common/constants';
 
-import {
-  createAgentPolicyMock,
-  createPackagePolicyMock,
-} from '../../../../../../../../common/mocks';
+import { createAgentPolicyMock, createPackagePolicyMock } from '../../../../../common/mocks';
 
-import { CustomFields } from '.';
+import { AgentPolicyCustomFields } from './agent_policy_custom_fields';
 
-describe('CustomFields', () => {
+describe('AgentPolicyCustomFields', () => {
   let testRenderer: TestRenderer;
   let renderResult: RenderResult;
   const mockUpdateAgentPolicy = jest.fn();
 
   const renderComponent = (agentPolicy: Partial<AgentPolicy | NewAgentPolicy>) => {
     renderResult = testRenderer.render(
-      <CustomFields agentPolicy={agentPolicy} updateAgentPolicy={mockUpdateAgentPolicy} />
+      <AgentPolicyCustomFields
+        agentPolicy={agentPolicy}
+        updateAgentPolicy={mockUpdateAgentPolicy}
+      />
     );
   };
 

x-pack/platform/plugins/shared/fleet/common/types/models/package_policy_schema.ts

@@ -5,18 +5,13 @@
  * 2.0.
  */
 import React from 'react';
-import styled from 'styled-components';
+import styled from '@emotion/styled';
 import { EuiDescribedFormGroup, EuiSpacer, EuiCallOut } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n-react';
 
-import type {
-  NewAgentPolicy,
-  AgentPolicy,
-  PackagePolicy,
-  PackagePolicyInput,
-} from '../../../../../types';
+import type { NewAgentPolicy, AgentPolicy, PackagePolicy, PackagePolicyInput } from '../../types';
 
-import { GLOBAL_DATA_TAG_EXCLUDED_INPUTS } from '../../../../../../../../common/constants';
+import { GLOBAL_DATA_TAG_EXCLUDED_INPUTS } from '../../../../../common/constants';
 
 import { GlobalDataTagsTable } from './global_data_tags_table';
 
@@ -33,7 +28,7 @@ const DescribedFormGroup = styled(EuiDescribedFormGroup)`
   }
 `;
 
-export const CustomFields: React.FunctionComponent<Props> = ({
+export const AgentPolicyCustomFields: React.FunctionComponent<Props> = ({
   agentPolicy,
   updateAgentPolicy,
   isDisabled,

x-pack/platform/plugins/shared/fleet/common/types/rest_spec/agentless_policy.ts

@@ -10,12 +10,12 @@ import React from 'react';
 import type { RenderResult } from '@testing-library/react';
 import { fireEvent, act } from '@testing-library/react';
 
-import { createFleetTestRendererMock, type TestRenderer } from '../../../../../../../mock';
-import type { GlobalDataTag } from '../../../../../../../../common/types';
+import { createFleetTestRendererMock, type TestRenderer } from '../../../../mock';
+import type { GlobalDataTag } from '../../../../../common/types';
 
 import { GlobalDataTagsTable } from './global_data_tags_table';
 
-jest.mock('../../../../../../../hooks/use_fleet_status', () => ({
+jest.mock('../../../../hooks/use_fleet_status', () => ({
   FleetStatusProvider: (props: any) => {
     return props.children;
   },