Skip to content

Commit 9b18d39

Browse files
authored
Revert "[ES|QL] Fix CSV report time range when exporting from Discover (elastic#216792)" (elastic#223249)
## Summary This reverts commit 6a0c173. Fixes elastic#223171. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
1 parent 7b8c157 commit 9b18d39

3 files changed

Lines changed: 4 additions & 31 deletions

File tree

src/platform/plugins/shared/discover/public/application/main/components/top_nav/app_menu_actions/get_share.tsx

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -136,17 +136,7 @@ export const getShareAppMenuItem = ({
136136
},
137137
sharingData: {
138138
isTextBased: isEsqlMode,
139-
locatorParams: [
140-
{
141-
id: locator.id,
142-
params: isEsqlMode
143-
? {
144-
...params,
145-
timeRange: timefilter.getAbsoluteTime(), // Will be used when generating CSV on server. See `filtersFromLocator`.
146-
}
147-
: params,
148-
},
149-
],
139+
locatorParams: [{ id: locator.id, params }],
150140
...searchSourceSharingData,
151141
// CSV reports can be generated without a saved search so we provide a fallback title
152142
title:

x-pack/test/functional/apps/discover/group1/__snapshots__/reporting.snap

Lines changed: 0 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/test/functional/apps/discover/group1/reporting.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
263263
expectSnapshot(csvFile).toMatch();
264264
});
265265

266-
it('generate a report using ES|QL for relative time range as absolute dates and time params', async () => {
266+
// TODO: Adjust and unskip when we have full support for toggling relative/absolute time ranges through the export UI
267+
// https://github.com/elastic/kibana/issues/223171
268+
it.skip('generate a report using ES|QL for relative time range as absolute dates and time params', async () => {
267269
const RECENT_DATA_INDEX_NAME = 'test_recent_data';
268270
const RECENT_DOC_COUNT = 500;
269271
const RECENT_DOC_END_DATE = moment().toISOString();

0 commit comments

Comments
 (0)