Skip to content

Commit b0d820a

Browse files
rudolfclaude
andauthored
Remove unused files in @kbn/observability-ai-assistant-app-plugin (dead code cleanup) (elastic#266813)
## Summary Removes **10 unused source files** (168 LoC) from `@kbn/observability-ai-assistant-app-plugin`, owned by `@elastic/obs-ai-team`. All verified to have **zero static importers** anywhere in the repo. This is one slice of a broader sweep across the codebase removing **399 files / 18.5k LoC** of dead code. Co-PRs cover the other ~28 teams' slices. The methodology is in elastic#266635 (skill PR). ## Files removed See the diff. Removals span the package — common shapes include: - Orphan barrel `index.ts` files where consumers consistently deep-import the sibling modules directly. - Dead React components, hooks, route handlers, or test helpers no longer referenced anywhere. ## Verification For every file: 1. **`knip` flagged it as unreachable** from the package's declared entry points (`server/index.ts`, `public/index.ts`, `common/index.ts`, plus deep-import-derived entries). 2. **Resolve-aware import scan** confirmed zero importers across the repo (Node-style: `<base>.ts`, `<base>.tsx`, `<base>/index.ts`, `<base>/index.tsx`). 3. **Package-id deep-import grep** for `@kbn/observability-ai-assistant-app-plugin/<sub>` references from other packages. 4. **`jest.mock()` string scan** for test mocks pointing at the path. 5. **Type-check passes** (`node scripts/type_check --project x-pack/solutions/observability/plugins/observability_ai_assistant_app/tsconfig.json`). ## Patterns observed (for context) The most common dead-code shapes in this slice: - **Orphan barrel `index.ts`** that re-exports from siblings — the commonest shape across the cleanup. - Other patterns vary by package (dead React components, dead route handlers, dead test fixtures). The full pattern catalog (across all teams) is in elastic#266635. 🤖 Generated by an AI agent following a verification recipe at `.agents/skills/dead-code-cleanup/SKILL.md` (PR elastic#266635). --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent ed8cf56 commit b0d820a

18 files changed

Lines changed: 0 additions & 267 deletions

x-pack/platform/plugins/private/translations/translations/de-DE.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35231,8 +35231,6 @@
3523135231
"xpack.observabilityAiAssistant.eisKnowledgeBase.dismissButton": "Verwerfen",
3523235232
"xpack.observabilityAiAssistant.eisKnowledgeBase.learnMoreButton": "Weitere Informationen",
3523335233
"xpack.observabilityAiAssistant.eisKnowledgeBase.title": "Elastic Inference Service (EIS) ist jetzt verfügbar",
35234-
"xpack.observabilityAiAssistant.experimentalTitle": "Technische Vorschau",
35235-
"xpack.observabilityAiAssistant.experimentalTooltip": "Diese Funktionalität befindet sich in der technischen Vorschau und kann in einer zukünftigen Version geändert oder vollständig entfernt werden. Elastic wird sich bemühen, alle Probleme zu beheben, aber die Features in der technischen Vorschau unterliegen nicht dem Support-SLA der offiziellen GA-Features.",
3523635234
"xpack.observabilityAiAssistant.failedLoadingResponseText": "Antwort konnte nicht geladen werden",
3523735235
"xpack.observabilityAiAssistant.failedToLoadResponse": "Antwort vom KI-Assistenten konnte nicht geladen werden",
3523835236
"xpack.observabilityAiAssistant.featureRegistry.featureName": "KI-Assistent für Observability",

x-pack/platform/plugins/private/translations/translations/fr-FR.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35168,8 +35168,6 @@
3516835168
"xpack.observabilityAiAssistant.eisKnowledgeBase.dismissButton": "Rejeter",
3516935169
"xpack.observabilityAiAssistant.eisKnowledgeBase.learnMoreButton": "En savoir plus",
3517035170
"xpack.observabilityAiAssistant.eisKnowledgeBase.title": "Elastic Inference Service (EIS) désormais disponible",
35171-
"xpack.observabilityAiAssistant.experimentalTitle": "Version d'évaluation technique",
35172-
"xpack.observabilityAiAssistant.experimentalTooltip": "Cette fonctionnalité est en version d'évaluation technique et pourra être modifiée ou retirée complètement dans une future version. Elastic s'efforcera de corriger tout problème, mais les fonctionnalités des versions d'évaluation technique ne sont pas soumises aux SLA de support des fonctionnalités officielles en disponibilité générale.",
3517335171
"xpack.observabilityAiAssistant.failedLoadingResponseText": "Échec de chargement de la réponse",
3517435172
"xpack.observabilityAiAssistant.failedToLoadResponse": "Échec du chargement d'une réponse de l'assistant d'intelligence artificielle",
3517535173
"xpack.observabilityAiAssistant.featureRegistry.featureName": "Assistant d'intelligence artificielle d'Observability",

x-pack/platform/plugins/private/translations/translations/ja-JP.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35351,8 +35351,6 @@
3535135351
"xpack.observabilityAiAssistant.eisKnowledgeBase.dismissButton": "閉じる",
3535235352
"xpack.observabilityAiAssistant.eisKnowledgeBase.learnMoreButton": "詳しくはこちら",
3535335353
"xpack.observabilityAiAssistant.eisKnowledgeBase.title": "Elastic Inference Service(EIS)が利用可能になりました",
35354-
"xpack.observabilityAiAssistant.experimentalTitle": "テクニカルプレビュー",
35355-
"xpack.observabilityAiAssistant.experimentalTooltip": "この機能はテクニカルプレビュー中であり、将来のリリースでは変更されたり完全に削除されたりする場合があります。Elasticはすべての問題の修正に努めますが、テクニカルプレビュー中の機能には正式なGA機能のサポートSLAが適用されません。",
3535635354
"xpack.observabilityAiAssistant.failedLoadingResponseText": "応答の読み込みに失敗しました",
3535735355
"xpack.observabilityAiAssistant.failedToLoadResponse": "AIアシスタントからの応答を読み込めませんでした",
3535835356
"xpack.observabilityAiAssistant.featureRegistry.featureName": "オブザーバビリティAI Assistant",

x-pack/platform/plugins/private/translations/translations/zh-CN.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35353,8 +35353,6 @@
3535335353
"xpack.observabilityAiAssistant.eisKnowledgeBase.dismissButton": "关闭",
3535435354
"xpack.observabilityAiAssistant.eisKnowledgeBase.learnMoreButton": "了解详情",
3535535355
"xpack.observabilityAiAssistant.eisKnowledgeBase.title": "Elastic Inference Service (EIS) 现已推出",
35356-
"xpack.observabilityAiAssistant.experimentalTitle": "技术预览",
35357-
"xpack.observabilityAiAssistant.experimentalTooltip": "此功能处于技术预览状态,在未来版本中可能会更改或完全移除。Elastic 将努力修复任何问题,但处于技术预览状态的功能不受正式 GA 功能支持 SLA 的约束。",
3535835356
"xpack.observabilityAiAssistant.failedLoadingResponseText": "无法加载响应",
3535935357
"xpack.observabilityAiAssistant.failedToLoadResponse": "无法加载来自 AI 助手的响应",
3536035358
"xpack.observabilityAiAssistant.featureRegistry.featureName": "Observability AI 助手",

x-pack/solutions/observability/plugins/observability_ai_assistant_app/moon.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,6 @@ dependsOn:
8686
- '@kbn/i18n-react'
8787
- '@kbn/utility-types'
8888
- '@kbn/alerts-ui-shared'
89-
- '@kbn/traced-es-client'
90-
- '@kbn/licensing-types'
9189
- '@kbn/utility-types-jest'
9290
- '@kbn/zod'
9391
- '@kbn/connector-schemas'

x-pack/solutions/observability/plugins/observability_ai_assistant_app/public/components/technical_preview_badge.tsx

Lines changed: 0 additions & 27 deletions
This file was deleted.

x-pack/solutions/observability/plugins/observability_ai_assistant_app/public/hooks/__storybook_mocks__/use_license.ts

Lines changed: 0 additions & 18 deletions
This file was deleted.

x-pack/solutions/observability/plugins/observability_ai_assistant_app/public/hooks/__storybook_mocks__/use_observability_ai_assistant.ts

Lines changed: 0 additions & 26 deletions
This file was deleted.

x-pack/solutions/observability/plugins/observability_ai_assistant_app/public/hooks/__storybook_mocks__/use_observability_ai_assistant_app_service.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

x-pack/solutions/observability/plugins/observability_ai_assistant_app/public/hooks/__storybook_mocks__/use_observability_ai_assistant_chat_service.ts

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)