You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #117 factored the launchers' shared work-stealing GPU subprocess pool into benchmarks/_common/gpu_pool.py:fan_out and refactored benchmarks/stage2_launch.py to use it. Three other launchers still carry their own duplicate device-queue + ThreadPoolExecutor implementations of the same pattern:
benchmarks/screen_launch.py
benchmarks/flavor_ablation_launch.py
benchmarks/loan_ladder_launch.py
Goal
Refactor those three launchers onto gpu_pool.fan_out, removing the duplicated pool code (as was done for stage2_launch).
Where
The three files above (each has its own ThreadPoolExecutor + Queue fan-out).
Context
PR #117 factored the launchers' shared work-stealing GPU subprocess pool into
benchmarks/_common/gpu_pool.py:fan_outand refactoredbenchmarks/stage2_launch.pyto use it. Three other launchers still carry their own duplicate device-queue +ThreadPoolExecutorimplementations of the same pattern:benchmarks/screen_launch.pybenchmarks/flavor_ablation_launch.pybenchmarks/loan_ladder_launch.pyGoal
Refactor those three launchers onto
gpu_pool.fan_out, removing the duplicated pool code (as was done forstage2_launch).Where
ThreadPoolExecutor+Queuefan-out).benchmarks/_common/gpu_pool.py:fan_out— the shared helper (cmd_builder(item, device) -> list[str], sets$MONONET_TORCH_DEVICE).tests/benchmarks/test_screen_launch.py,test_flavor_ablation_launch.py,test_loan_ladder_launch.py— update thesubprocess.runmonkeypatch target tobenchmarks._common.gpu_pool.subprocess.run(as done fortest_stage2_launch.pyin feat(bench): HP-search sensitivity curves (spec + plan + implementation) #117).Acceptance criteria
fan_out; no residualThreadPoolExecutor/Queuein them.References
gpu_pool.fan_out,stage2_launchrefactor).