getInstance with only string not working

[BorntraegerMarc]

According to the docs https://db-migrate.readthedocs.io/en/latest/API/programable/ this should work: let dbmigrate = DBMigrate.getInstance(true, './path/to/database.json');

Probably because here https://github.com/db-migrate/node-db-migrate/blob/master/api.js#L104 never the type string is checked. Should I do a PR?

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[BorntraegerMarc]

Also having database.json at the end of the path throws an error:
Could not find database config file './path/to/database.json/database.json'

Expected behavior: That the last string database.json is not added.

[BorntraegerMarc]

Temporary workaround: let dbmigrate = DBMigrate.getInstance(true, {cwd: './path/to/database.json'});

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[BorntraegerMarc]

Don't close it. The issue has not been resolved yet 😄

[wzrdtales]

LGTM, it only defines the path where to search for database.json, stripping database.json when it is there and it really don't exist a folder with that name including a database.json, should probably added.

Wanna create a PR for that?
Logical entrypoint would be either here

node-db-migrate/api.js

Lines 49 to 50 in 73904ac

	if (typeof options.config === 'string') {
	internals.configFile = options.config;

or here

node-db-migrate/lib/commands/set-default-argv.js

Line 4 in 73904ac

module.exports = function (internals, isModule) {