Programmable API createDatabase arguments are overridden

[tjokimie]

I'm submitting a...

• Bug report
• Feature request
• Question

Current behavior

Command line parameters override createDatabase parameters in Programable API.

$ DATABASE_URL=postgres://localhost/postgres node index.js
[INFO] Created database "expected"
$ DATABASE_URL=postgres://localhost/postgres node index.js unexpected
[INFO] Created database "unexpected"

Expected behavior

I would expect parameters provided to createDatabase always override possible command line arguments.

$ DATABASE_URL=postgres://localhost/postgres node index.js
[INFO] Created database "expected"
$ DATABASE_URL=postgres://localhost/postgres node index.js unexpected
[INFO] Created database "expected"

Minimal reproduction of the problem with instructions

$ cat index.js
var dbmigrate = require('db-migrate');
var dbm = dbmigrate.getInstance(true);
dbm.createDatabase('expected')
.then(function() {
  process.exit(0);
});

What is the motivation / use case for changing the behavior?

Using createDatabase through Programable API in an program that has command line args is not possible at the moment.

Environment

db-migrate version: 0.11.1
db-migrate-pg version: 0.4.0

Additional information:
- Node version: v10.6.0
- Platform:  Mac

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[KingRial]

I am problably missing something but, shouldn't you just pass the desired configuration ?

This should be the way to handle db-migrate programmatically:

var dbmigrate = require('db-migrate');
var dbm = dbmigrate.getInstance(true, {
  env: 'dev',
  ... all the other options you desire ...
  config: {
   dev: {
     host: 'foo.com',
     user: 'Foo',
     password: 'FooPass',
     database: 'FooMysql',
     driver: 'mysql',
     multipleStatements: true
   }
  }
});
dbm.createDatabase('expected')
.then(function() {
  process.exit(0);
});

Otherwise it correctly looks for configuration used by command line.

[tjokimie]

@KingRial Did you try running your example with node index.js and node index.js unexpected? I get the same problem if I pass the configuration directly to getInstance. Command line parameters override parameters provided for createDatabase.

For example with the following script:

var dbmigrate = require('db-migrate');
var config = {
  dev: {
    host: 'localhost',
    user: 'postgres',
    password: 'password',
    database: 'postgres',
    driver: 'pg'
  }
};
var dbm = dbmigrate.getInstance(true, { env: 'dev', config });
dbm.createDatabase('expected')
.then(function() {
  process.exit(0);
});

Running node index.js will create database expected but running node index.js unexpected will create database unexpected.

[KingRial]

Now I understand what happens :) My bad!

I can confirm the problem (it doesn't matter what driver you use; even on mongo and MySQL it occurs)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[wzrdtales]

I will check this, probably conflicting with the general config hirarchy.

[trubachev]

Faced this bug right now. Found the exact line where it happening

node-db-migrate/lib/commands/db.js

Line 10 in 3c4bd77

internals.argv.dbname = internals.argv._.shift().toString();

[dnjstrom]

Quick note: This bug is affecting both createDatabase and dropDatabase since both rely on the executeDB function, as mentioned by @trubachev.

[AlexGilleran]

You can work around it by manually reaching into internals:

dbmigrate.internals.argv._[0] = "test";
await dbmigrate.createDatabase("test");