Skip to content

Commit 41b06e4

Browse files
authored
changed selector icon and updated mod-arch packages (kubeflow#2286)
* changed selector icon and updated mod-arch packages Signed-off-by: rsun19 <robertssun1234@gmail.com> * changed icon size Signed-off-by: rsun19 <robertssun1234@gmail.com> --------- Signed-off-by: rsun19 <robertssun1234@gmail.com>
1 parent e8537d3 commit 41b06e4

4 files changed

Lines changed: 28 additions & 26 deletions

File tree

clients/ui/frontend/package-lock.json

Lines changed: 17 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

clients/ui/frontend/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@
100100
"classnames": "^2.2.6",
101101
"dompurify": "^3.2.4",
102102
"lodash-es": "^4.17.23",
103-
"mod-arch-core": "~1.2.2",
104-
"mod-arch-kubeflow": "~1.2.2",
105-
"mod-arch-shared": "~1.2.2",
103+
"mod-arch-core": "~1.8.2",
104+
"mod-arch-kubeflow": "~1.8.2",
105+
"mod-arch-shared": "~1.8.2",
106106
"react": "^18",
107107
"react-dom": "^18",
108108
"react-markdown": "^10.1.0",

clients/ui/frontend/src/app/pages/modelRegistry/screens/ModelRegistrySelector.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,14 @@ import {
1515
} from '@patternfly/react-core';
1616
import text from '@patternfly/react-styles/css/utilities/Text/text';
1717
import truncateStyles from '@patternfly/react-styles/css/components/Truncate/truncate';
18-
import { InfoCircleIcon, BlueprintIcon } from '@patternfly/react-icons';
18+
import { InfoCircleIcon } from '@patternfly/react-icons';
1919
import {
2020
WhosMyAdministrator,
2121
KubeflowDocs,
2222
SimpleSelect,
2323
InlineTruncatedClipboardCopy,
24+
TypedObjectIcon,
25+
ProjectObjectType,
2426
} from 'mod-arch-shared';
2527
import { useBrowserStorage } from 'mod-arch-core';
2628
import { useThemeContext } from 'mod-arch-kubeflow';
@@ -147,11 +149,9 @@ const ModelRegistrySelector: React.FC<ModelRegistrySelectorProps> = ({
147149

148150
return (
149151
<Flex spaceItems={{ default: 'spaceItemsSm' }} alignItems={{ default: 'alignItemsCenter' }}>
150-
<FlexItem>
151-
<Icon>
152-
<BlueprintIcon />
153-
</Icon>
154-
</FlexItem>
152+
<Icon iconSize="xl" isInline>
153+
<TypedObjectIcon resourceType={ProjectObjectType.modelRegistryNavigator} />
154+
</Icon>
155155
<FlexItem>
156156
<Bullseye>Model registry</Bullseye>
157157
</FlexItem>

clients/ui/frontend/src/app/standalone/__tests__/NavBar.test.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ describe('NavBar mandatory namespace functionality', () => {
7272
namespaces: [{ name: mandatoryNamespace }],
7373
preferredNamespace: { name: mandatoryNamespace },
7474
updatePreferredNamespace: jest.fn(),
75+
clearStoredNamespace: jest.fn(),
7576
namespacesLoaded: true,
7677
namespacesLoadError: undefined,
7778
initializationError: undefined,
@@ -101,6 +102,7 @@ describe('NavBar mandatory namespace functionality', () => {
101102
namespaces: mockNamespaces,
102103
preferredNamespace: { name: 'namespace-1' },
103104
updatePreferredNamespace: jest.fn(),
105+
clearStoredNamespace: jest.fn(),
104106
namespacesLoaded: true,
105107
namespacesLoadError: undefined,
106108
initializationError: undefined,

0 commit comments

Comments
 (0)