Skip to content

Commit dd44827

Browse files
authored
Switch to using adming_client for IG tests (opendatahub-io#346)
This is because the unprivileged_client is not allowed to perform CRUD operations over InferenceServices. Thus, using the admin_client while we configure the unprivileged one.
1 parent 9984343 commit dd44827

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

  • tests/model_serving/model_server/inference_graph

tests/model_serving/model_server/inference_graph/conftest.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
@pytest.fixture
2121
def dog_breed_inference_graph(
2222
request: FixtureRequest,
23-
unprivileged_client: DynamicClient,
23+
admin_client: DynamicClient,
2424
unprivileged_model_namespace: Namespace,
2525
dog_cat_inference_service: InferenceService,
2626
dog_breed_inference_service: InferenceService,
@@ -69,7 +69,7 @@ def dog_breed_inference_graph(
6969
pass
7070

7171
with InferenceGraph(
72-
client=unprivileged_client,
72+
client=admin_client,
7373
name=name,
7474
namespace=unprivileged_model_namespace.name,
7575
nodes=nodes,
@@ -82,13 +82,13 @@ def dog_breed_inference_graph(
8282

8383
@pytest.fixture(scope="class")
8484
def dog_cat_inference_service(
85-
unprivileged_client: DynamicClient,
85+
admin_client: DynamicClient,
8686
unprivileged_model_namespace: Namespace,
8787
ovms_kserve_serving_runtime: ServingRuntime,
8888
models_endpoint_s3_secret: Secret,
8989
) -> Generator[InferenceService, Any, Any]:
9090
with create_isvc(
91-
client=unprivileged_client,
91+
client=admin_client,
9292
name="dog-cat-classifier",
9393
namespace=unprivileged_model_namespace.name,
9494
runtime=ovms_kserve_serving_runtime.name,
@@ -103,13 +103,13 @@ def dog_cat_inference_service(
103103

104104
@pytest.fixture(scope="class")
105105
def dog_breed_inference_service(
106-
unprivileged_client: DynamicClient,
106+
admin_client: DynamicClient,
107107
unprivileged_model_namespace: Namespace,
108108
ovms_kserve_serving_runtime: ServingRuntime,
109109
models_endpoint_s3_secret: Secret,
110110
) -> Generator[InferenceService, Any, Any]:
111111
with create_isvc(
112-
client=unprivileged_client,
112+
client=admin_client,
113113
name="dog-breed-classifier",
114114
namespace=unprivileged_model_namespace.name,
115115
runtime=ovms_kserve_serving_runtime.name,
@@ -138,19 +138,19 @@ def inference_graph_sa_token_with_access(
138138

139139
@pytest.fixture
140140
def service_account_with_access(
141-
unprivileged_client: DynamicClient,
141+
admin_client: DynamicClient,
142142
unprivileged_model_namespace: Namespace,
143143
dog_breed_inference_graph: InferenceGraph,
144144
bare_service_account: ServiceAccount,
145145
) -> Generator[ServiceAccount, Any, Any]:
146146
with create_inference_graph_view_role(
147-
client=unprivileged_client,
147+
client=admin_client,
148148
name=f"{dog_breed_inference_graph.name}-view",
149149
namespace=unprivileged_model_namespace.name,
150150
resource_names=[dog_breed_inference_graph.name],
151151
) as role:
152152
with RoleBinding(
153-
client=unprivileged_client,
153+
client=admin_client,
154154
namespace=unprivileged_model_namespace.name,
155155
name=f"{bare_service_account.name}-view",
156156
role_ref_name=role.name,
@@ -164,7 +164,7 @@ def service_account_with_access(
164164
@pytest.fixture
165165
def bare_service_account(
166166
request: FixtureRequest,
167-
unprivileged_client: DynamicClient,
167+
admin_client: DynamicClient,
168168
unprivileged_model_namespace: Namespace,
169169
) -> Generator[ServiceAccount, Any, Any]:
170170
try:
@@ -174,7 +174,7 @@ def bare_service_account(
174174
name = "sa-" + token_hex(4)
175175

176176
with ServiceAccount(
177-
client=unprivileged_client,
177+
client=admin_client,
178178
namespace=unprivileged_model_namespace.name,
179179
name=name,
180180
) as sa:

0 commit comments

Comments
 (0)