Skip to content

Commit c893e47

Browse files
CB-4949 merge runtime and root config in original properties (#2667)
Co-authored-by: Daria Marutkina <[email protected]>
1 parent 0151edf commit c893e47

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/utils/WebAppUtils.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,16 @@ public static SMAuthenticationManager getAuthManager(WebApplication application)
7474
}
7575

7676
@SuppressWarnings("unchecked")
77-
public static Map<String, Object> mergeConfigurations(Map<String, Object> origin, Map<String, Object> additional) {
77+
public static Map<String, Object> mergeConfigurations(
78+
Map<String, Object> priorityConfiguration,
79+
Map<String, Object> additional
80+
) {
7881
var resultConfig = new HashMap<String, Object>();
79-
Set<String> rootKeys = new HashSet<>(origin.keySet());
82+
Set<String> rootKeys = new HashSet<>(priorityConfiguration.keySet());
8083
rootKeys.addAll(additional.keySet());
8184

8285
for (var rootKey : rootKeys) {
83-
var originValue = origin.get(rootKey);
86+
var originValue = priorityConfiguration.get(rootKey);
8487
var additionalValue = additional.get(rootKey);
8588

8689
if (originValue == null || additionalValue == null) {

server/bundles/io.cloudbeaver.server/src/io/cloudbeaver/server/CBServerConfigurationController.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,13 @@ protected Map<String, Object> readConfiguration(Path configPath) throws DBExcept
283283
Map<String, Object> configProps = new LinkedHashMap<>();
284284
if (Files.exists(configPath)) {
285285
log.debug("Read configuration [" + configPath.toAbsolutePath() + "]");
286+
287+
configProps.putAll(readConfigurationFile(configPath));
288+
289+
var mergedOriginalConfigs = WebAppUtils.mergeConfigurations(configProps, originalConfigurationProperties);
290+
this.originalConfigurationProperties.clear();
286291
// saves original configuration file
287-
this.originalConfigurationProperties.putAll(readConfigurationFile(configPath));
292+
this.originalConfigurationProperties.putAll(mergedOriginalConfigs);
288293

289294
configProps.putAll(readConfigurationFile(configPath));
290295
patchConfigurationWithProperties(configProps); // patch original properties

0 commit comments

Comments
 (0)