Use Puma, update RuboCop, CI.

Author: dblock

.github/workflows/lint.yml

@@ -0,0 +1,14 @@
+name: lint
+
+on: [push, pull_request]
+
+jobs:
+  RuboCop:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "3.4.6"
+          bundler-cache: true
+      - run: bundle exec rubocop

.github/workflows/rubocop.yml

@@ -1,25 +1,26 @@
-name: Tests
+name: test
+
 on: [push, pull_request]
+
 jobs:
-  test:
+  RSpec:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: '3.3.5'
-      - uses: supercharge/mongodb-github-action@1.12.0
+      - uses: actions/checkout@v3
+      - uses: browser-actions/setup-firefox@latest
         with:
-          mongodb-version: '7.0'
+          firefox-version: '143.0.3'
       - uses: browser-actions/setup-geckodriver@latest
         with:
-          geckodriver-version: '0.35.0'
-      - uses: browser-actions/setup-firefox@v1.5.2
+          geckodriver-version: "0.36.0"
+      - uses: supercharge/mongodb-github-action@1.7.0
         with:
-          firefox-version: '134.0.1'
-      - run: |
-          bundle install
+          mongodb-version: "8.0"
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "3.4.6"
+          bundler-cache: true
       - uses: GabrielBB/xvfb-action@v1
-        with:          
+        with:
           run: |
-            bundle exec rake spec
+            bundle exec rake spec

.github/workflows/test.yml

@@ -31,7 +31,7 @@ Style/HashTransformValues:
 
 inherit_from: .rubocop_todo.yml
 
-require:
+plugins:
   - rubocop-rake
   - rubocop-capybara
   - rubocop-rspec

.rubocop.yml

@@ -1,18 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2025-05-04 16:11:52 UTC using RuboCop version 1.66.1.
+# on 2025-10-02 12:37:09 UTC using RuboCop version 1.81.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: link_or_button, strict
-Capybara/ClickLinkOrButtonStyle:
-  Exclude:
-    - 'spec/integration/update_cc_spec.rb'
-
 # Offense count: 3
 Capybara/SpecificActions:
   Exclude:
@@ -34,12 +27,18 @@ Lint/NonLocalExitFromIterator:
 
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowedMethods.
+# Configuration parameters: AllowedMethods, InferNonNilReceiver, AdditionalNilMethods.
 # AllowedMethods: instance_of?, kind_of?, is_a?, eql?, respond_to?, equal?
+# AdditionalNilMethods: present?, blank?, try, try!
 Lint/RedundantSafeNavigation:
   Exclude:
     - 'slack-sup/models/user.rb'
 
+# Offense count: 2
+Lint/UselessConstantScoping:
+  Exclude:
+    - 'slack-sup/models/team.rb'
+
 # Offense count: 1
 # Configuration parameters: ExpectMatchingDefinition, CheckDefinitionPathHierarchy, CheckDefinitionPathHierarchyRoots, Regex, IgnoreExecutableScripts, AllowedAcronyms.
 # CheckDefinitionPathHierarchyRoots: lib, spec, test, src
@@ -80,7 +79,7 @@ Naming/MethodParameterName:
 # Offense count: 6
 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
-# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
+# AllowedIdentifiers: TLS1_1, TLS1_2, capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
 Naming/VariableNumber:
   Exclude:
     - 'spec/api/endpoints/rounds_endpoint_spec.rb'
@@ -125,7 +124,7 @@ RSpec/ExpectInHook:
     - 'spec/slack-sup/commands/subscription_spec.rb'
     - 'spec/slack-sup/commands/unsubscribe_spec.rb'
 
-# Offense count: 60
+# Offense count: 61
 # Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
 RSpec/IndexedLet:
   Exclude:
@@ -150,7 +149,7 @@ RSpec/InstanceVariable:
     - 'spec/support/api/endpoints/it_behaves_like_a_cursor_api.rb'
     - 'spec/support/api/endpoints/it_behaves_like_a_team_token_api.rb'
 
-# Offense count: 47
+# Offense count: 48
 RSpec/LetSetup:
   Exclude:
     - 'spec/api/endpoints/stats_endpoint_spec.rb'
@@ -205,8 +204,7 @@ RSpec/RepeatedDescription:
     - 'spec/slack-sup/commands/set_spec.rb'
 
 # Offense count: 22
-# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
-# Include: **/*_spec.rb
+# Configuration parameters: CustomTransform, IgnoreMethods, IgnoreMetadata.
 RSpec/SpecFilePathFormat:
   Enabled: false
 
@@ -237,6 +235,15 @@ RSpec/VoidExpect:
     - 'spec/integration/homepage_spec.rb'
     - 'spec/models/round_spec.rb'
 
+# Offense count: 5
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/CollectionQuerying:
+  Exclude:
+    - 'slack-sup/api/helpers/error_helpers.rb'
+    - 'slack-sup/api/helpers/sort_helpers.rb'
+    - 'slack-sup/commands/admins.rb'
+    - 'slack-sup/models/round.rb'
+
 # Offense count: 2
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Style/GlobalStdStream:
@@ -289,13 +296,7 @@ Style/MultilineWhenThen:
     - 'slack-sup/commands/opt.rb'
     - 'slack-sup/commands/set.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/NestedTernaryOperator:
-  Exclude:
-    - 'slack-sup/models/team.rb'
-
-# Offense count: 11
+# Offense count: 12
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns.
 # SupportedStyles: predicate, comparison

.rubocop_todo.yml

@@ -1,5 +1,6 @@
 ### Changelog
 
+* 2025/10/02: Upgraded to Ruby 3.4.6 - [@dblock](https://github.com/dblock).
 * 2025/05/04: Visibly handle vacationing users - [@dblock](https://github.com/dblock).
 * 2025/02/22: Added `data [n|all]` and only export the last round by default - [@dblock](https://github.com/dblock).
 * 2025/02/04: Added `admins` that shows all admins - [@dblock](https://github.com/dblock).

CHANGELOG.md

@@ -1,6 +1,6 @@
 source 'http://rubygems.org'
 
-ruby '3.3.5'
+ruby '3.4.6'
 
 gem 'ambit'
 gem 'bytesize'
@@ -15,16 +15,16 @@ gem 'mongoid'
 gem 'mongoid-scroll'
 gem 'newrelic_rpm'
 gem 'ostruct'
+gem 'puma'
 gem 'rack', '~> 3.0.16'
 gem 'rack-robotz'
 gem 'rack-server-pages'
 gem 'rubyzip'
 gem 'slack-ruby-bot-server'
 gem 'slack-ruby-bot-server-mailchimp'
-gem 'slack-ruby-bot-server-rtm'
+gem 'slack-ruby-bot-server-rtm', '~> 0.3.0'
 gem 'slack-ruby-client'
 gem 'stripe', '~> 1.58.0'
-gem 'unicorn'
 gem 'wannabe_bool'
 
 group :development, :test do