From 91e6d8b14f9bb936267133dd9102e85d66d9270e Mon Sep 17 00:00:00 2001 From: Mike Alfare Date: Tue, 17 Dec 2024 12:01:52 -0500 Subject: [PATCH 1/4] add triage workflow and labels to new issues --- .github/ISSUE_TEMPLATE/bug_report.yml | 2 +- .github/ISSUE_TEMPLATE/feature_request.yml | 2 +- .github/ISSUE_TEMPLATE/other.yml | 2 +- .github/workflows/issue-triage.yml | 20 ++++++++++++++++++++ 4 files changed, 23 insertions(+), 3 deletions(-) create mode 100644 .github/workflows/issue-triage.yml diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index d7235eaa..ea9925d1 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,7 +1,7 @@ name: 🐞 Bug description: Report a bug or an issue you've found in dbt-athena title: "[Bug] " -labels: ["bug"] +labels: ["bug","triage"] body: - type: markdown attributes: diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index 39a9418b..06a3d77f 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -1,7 +1,7 @@ name: ✨ Feature description: Propose a straightforward extension of dbt functionality title: "[Feature] <title>" -labels: ["feature"] +labels: ["feature","triage"] body: - type: markdown attributes: diff --git a/.github/ISSUE_TEMPLATE/other.yml b/.github/ISSUE_TEMPLATE/other.yml index ea166843..1f8549a5 100644 --- a/.github/ISSUE_TEMPLATE/other.yml +++ b/.github/ISSUE_TEMPLATE/other.yml @@ -1,7 +1,7 @@ name: Other description: Anything that is not a bug or a feature title: "<title>" -labels: [] +labels: ["triage"] body: - type: checkboxes attributes: diff --git a/.github/workflows/issue-triage.yml b/.github/workflows/issue-triage.yml new file mode 100644 index 00000000..7d2ed8e0 --- /dev/null +++ b/.github/workflows/issue-triage.yml @@ -0,0 +1,20 @@ +name: "Issue triage" +run-name: "Issue triage - #${{ github.event.issue.number }}: ${{ github.event.issue.title }} - ${{ github.actor }}" + +on: issue_comment + +defaults: + run: + shell: bash + +permissions: + issues: write + +jobs: + triage: + if: contains(github.event.issue.labels.*.name, 'awaiting_response') + uses: dbt-labs/actions/.github/workflows/swap-labels.yml@main + with: + add_label: "triage" + remove_label: "awaiting_response" + secrets: inherit From 80133da2fc87d20d497240ee76146597de068722 Mon Sep 17 00:00:00 2001 From: Mike Alfare <mike.alfare@dbtlabs.com> Date: Thu, 19 Dec 2024 11:20:44 -0500 Subject: [PATCH 2/4] fix job dependency reference --- .github/workflows/pull-request-checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request-checks.yml b/.github/workflows/pull-request-checks.yml index b202ef48..c94e52c7 100644 --- a/.github/workflows/pull-request-checks.yml +++ b/.github/workflows/pull-request-checks.yml @@ -73,7 +73,7 @@ jobs: results: name: "Pull request checks" if: always() - needs: [code-quality, changelog, verify-builds, unit-tests, integration-tests] + needs: [code-quality, changelog-entry, verify-builds, unit-tests, integration-tests] runs-on: ${{ vars.DEFAULT_RUNNER }} steps: - uses: re-actors/alls-green@release/v1 From 02549604f137f5cd3aa90b0cf1fe4f95f4f0fa20 Mon Sep 17 00:00:00 2001 From: Mike Alfare <mike.alfare@dbtlabs.com> Date: Thu, 19 Dec 2024 13:56:56 -0500 Subject: [PATCH 3/4] remove file accidentally re-added during rebase --- .github/ISSUE_TEMPLATE/other.yml | 30 ------------------------------ 1 file changed, 30 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/other.yml diff --git a/.github/ISSUE_TEMPLATE/other.yml b/.github/ISSUE_TEMPLATE/other.yml deleted file mode 100644 index 1f8549a5..00000000 --- a/.github/ISSUE_TEMPLATE/other.yml +++ /dev/null @@ -1,30 +0,0 @@ -name: Other -description: Anything that is not a bug or a feature -title: "<title>" -labels: ["triage"] -body: -- type: checkboxes - attributes: - label: Is this your first time submitting an issue in dbt-athena? - description: > - We want to make sure that features are distinct and discoverable, - so that other members of the community can find them and offer their thoughts. - - Issues are the right place to request straightforward extensions of existing dbt functionality. - For "big ideas" about future capabilities of dbt, we ask that you open a - options: - - label: I have searched the existing issues, and I could not find an existing issue for this feature - required: true -- type: textarea - attributes: - label: Describe your request/question - description: A clear and concise description of what you want to happen. - validations: - required: true -- type: textarea - attributes: - label: Anything else? - description: | - Links? References? Anything that will give us more context about the requests or question - validations: - required: false From 043d52a22d406b6e44e4b1836a0ee97e7a94b83f Mon Sep 17 00:00:00 2001 From: Mike Alfare <mike.alfare@dbtlabs.com> Date: Thu, 19 Dec 2024 13:58:13 -0500 Subject: [PATCH 4/4] fix formatting --- .github/ISSUE_TEMPLATE/bug_report.yml | 2 +- .github/ISSUE_TEMPLATE/feature-request.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 98476d8d..2cfb67e1 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,7 +1,7 @@ name: 🐞 Bug description: Report a bug or an issue you've found with dbt-athena title: "[Bug] <title>" -labels: ["bug","triage"] +labels: ["bug", "triage"] body: - type: markdown attributes: diff --git a/.github/ISSUE_TEMPLATE/feature-request.yml b/.github/ISSUE_TEMPLATE/feature-request.yml index 06a3d77f..2c1d8c4f 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.yml +++ b/.github/ISSUE_TEMPLATE/feature-request.yml @@ -1,7 +1,7 @@ name: ✨ Feature description: Propose a straightforward extension of dbt functionality title: "[Feature] <title>" -labels: ["feature","triage"] +labels: ["feature", "triage"] body: - type: markdown attributes: