[BUG] pre-commit hooks don't work when the `dbt-project.yml` isn't in the repository root directory.

[peter-malcolm-bw]

I think the pre-commit hooks added in #172 and improved in #183 have an implicit assumption that the dbt-project.yml lives in the repository root directory.

Our repository folder structure looks like this:

.git 
.github/
jaffle-shop
  dbt_project.yml
  models/
     mart/
       schema.yml

Running the pre-commit hook against a project with changes:

pre-commit run --all-files --verbose dbt-autofix-fix
Fix dbt deprecations.....................................................Passed
- hook id: dbt-autofix-fix
- duration: 2.49s

Error: dbt_project.yml not found in /Path/To/JaffleProject/jaffle-shop
Error: dbt_project.yml not found in /Path/To/JaffleProject/jaffle-shop
Error: dbt_project.yml not found in /Path/To/JaffleProject/jaffle-shop
Error: dbt_project.yml not found in /Path/To/JaffleProject/jaffle-shop

Running the cli script with path from the repository root works:

uvx dbt-autofix deprecations --path=jaffle-shop
Refactored /Path/To/JaffleProject/jaffle-shop/models/mart/schema.yml:

I've had a look at pre_commit_hooks/check_deprecations.py and it doesn't look like the root_path is configurable. Could this be exposed as a CLI arg in the pre-commit hook so we can write something like?

# .pre-commit-config.yaml

repos: 

- repo: https://github.com/dbt-labs/dbt-autofix
  rev: v0.16.1
  hooks:
    - id: dbt-autofix-fix
      args: [--project-dir=jaffle-shop]

[chayac]

Hey, thank you for the report! I agree that it should have the same functionality as the CLI for changing root directory. I'll take a look at potential fixes and update here.

[jairus-m]

Hi @chayac , I added the pre-commit hook and am familiar with the code. If you haven't already, id be more than happy to open a PR for this.

https://github.com/jairus-m/dbt-autofix/tree/jairus/add-path-arg-to-pre-commit

[jairus-m]

Hello @peter-malcolm-bw . I just tested this locally, but feel free to try it on your end as well:

repos:
  - repo: https://github.com/jairus-m/dbt-autofix
    rev: 77c1c8638bb342defedd470a1b17449f7da3cdd5 # latest commit on my feature branch
    hooks:
      - id: dbt-autofix-fix
        args: [--path=jaffle-shop]

also, I do think it may be worth it for me to look into opening an issue for this getting an error message with --verbose while the pre-commit hook itself saying "Passed"

This definitely should not be the case! Thank you for your patience.

[peter-malcolm-bw]

@jairus-m - I've just tested the PR you raised against my repository locally and it appears to be working exactly as intended. 🎉 🔥 🚀

Would you be able to share any sense of the expected timeline for merging this into main?

Thank you so much for looking into this!

[jairus-m]

@peter-malcolm-bw Unfortunately, I don't have a good sense for timing (I'm just a community contributor) but would imagine since the PR is open and we both did validation on my branch, that as soon as a maintainer can take a look, we should be ready to rock!

[jairus-m]

@peter-malcolm-bw merged to main - should be good to go!