`dbt-autofix-fix` pre-commit hook silently passes when dbt project is in a subdirectory

[shiv-io]

The dbt-autofix-fix (and dbt-autofix-check) pre-commit hooks always pass without fixing anything when the dbt project lives in a subdirectory of the repo (e.g. ./dbt/). No error or warning is emitted — the hook reports Passed even though deprecations exist.

Environment

• dbt-autofix version: v0.20.3
• Repo layout: monorepo where the dbt project is at ./dbt/ (not the repo root)
• pre-commit version: 4.5.1
• Environment variable DBT_PROJECT_DIR set to <repo-root>/dbt

Steps to reproduce

1. Have a repo where dbt_project.yml lives at ./dbt/dbt_project.yml (not ./dbt_project.yml)
2. Add the hook to .pre-commit-config.yaml:

   - repo: https://github.com/dbt-labs/dbt-autofix
     rev: v0.20.3
     hooks:
       - id: dbt-autofix-fix
         args: [--path=dbt]

4. Run pre-commit install to install the hook
5. Introduce a YAML file with a known deprecation (e.g. dbt_utils.accepted_range test arguments not nested under arguments:)
6. Run uvx dbt-autofix deprecations --dry-run to return the list of deprecations and confirm the deprecation added above is listed
7. Run pre-commit run dbt-autofix-fix --all-files

Expected: Hook detects and fixes the deprecation, exits 1, and asks you to re-stage.

Actual: Hook reports Passed with exit code 0. No files are modified.

[shiv-io]

For reference, I got the following workaround to work, but can't confirm its stability:

Workaround

Until this is fixed, a repo: local hook that calls changeset_all_files directly works correctly:

- repo: local
  hooks:
    - id: dbt-autofix-fix
      name: Fix dbt deprecations
      entry: python scripts/dbt_autofix_hook.py
      language: python
      additional_dependencies: [dbt-autofix==0.20.3]
      pass_filenames: false
      files: ^dbt/
      types_or: [yaml, sql, python]

# scripts/dbt_autofix_hook.py
import sys
from pathlib import Path
from dbt_autofix.refactor import apply_changesets, changeset_all_files
from dbt_autofix.retrieve_schemas import SchemaSpecs

def main() -> int:
    schema_specs = SchemaSpecs(version=None)
    yaml_results, sql_results, python_results = changeset_all_files(
        path=Path("dbt"), schema_specs=schema_specs, dry_run=False,
        exclude_dbt_project_keys=False, select=None, include_packages=False,
        include_private_packages=False, behavior_change=False, all=False, semantic_layer=False,
    )
    apply_changesets(yaml_results, sql_results, python_results, json_output=False)
    has_changes = (
        any(c.refactored for c in yaml_results)
        or any(c.refactored for c in sql_results)
        or any(c.refactored for c in python_results)
    )
    return 1 if has_changes else 0

if __name__ == "__main__":
    sys.exit(main())

[chayac]

I think this functionality was added a while back, see this thread: #244

Here is what the author suggested, can you see if that works for you?

repos:
  - repo: https://github.com/jairus-m/dbt-autofix
    rev: 77c1c8638bb342defedd470a1b17449f7da3cdd5 # latest commit on my feature branch
    hooks:
      - id: dbt-autofix-fix
        args: [--path=jaffle-shop]

[shiv-io]

@chayac I should have included this context in my original description, but I actually did include the --path as you are suggesting while I tested this. It did not work.

[chayac]

Hmm, this is weird - I can repro this when I run pre-commit run dbt-autofix-fix --all-files, but it works correctly when I actually try to commit the files:

.pre-commit-config.yaml:

repos:
   - repo: https://github.com/dbt-labs/dbt-autofix
     rev: v0.20.3
     hooks:
       - id: dbt-autofix-fix
         args: [--path=dbt]

Output:

chaya@Chaya-Carey nested_project % pre-commit run --all-files dbt-autofix-fix                   
Fix dbt deprecations.....................................................Passed
chaya@Chaya-Carey nested_project % git add .                                 
chaya@Chaya-Carey nested_project % git commit -m "test precommit"            
Fix dbt deprecations.....................................................Failed
- hook id: dbt-autofix-fix
- exit code: 1
- files were modified by this hook

Can you see if actually committing the files fails or succeeds?

[shiv-io]

@chayac Hmm, it let me commit the file too.

Introduced a change to the YML so it's in the working tree:

(dbt) ➜  dbt git:(DA-5436-add-pre-commit-hook-dbt-autofix) ✗ git status
On branch DA-5436-add-pre-commit-hook-dbt-autofix
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   models/core/active_users_refactored.yml

no changes added to commit (use "git add" and/or "git commit -a")

Dry run to confirm a fix is needed:

(dbt) ➜  dbt git:(DA-5436-add-pre-commit-hook-dbt-autofix) ✗ uvx dbt-autofix deprecations --dry-run
-- Dry run mode, not applying changes --

DRY RUN - NOT APPLIED: Refactored /Users/shivgupta/projects/maple-data/dbt/models/core/active_users_refactored.yml:
  restructure_yaml_keys
    Test 'accepted_values' - Custom test argument 'values' moved under 'arguments'.

Try running the hook:

(dbt) ➜  dbt git:(DA-5436-add-pre-commit-hook-dbt-autofix) ✗ pre-commit run dbt-autofix-fix --all-files
Fix dbt deprecations.....................................................Passed

Try committing the bad file:

(dbt) ➜  dbt git:(DA-5436-add-pre-commit-hook-dbt-autofix) ✗ git add .                    
(dbt) ➜  dbt git:(DA-5436-add-pre-commit-hook-dbt-autofix) ✗ git commit -m "try to commit"
Tabs remover.............................................................Passed
check yaml...............................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
Fix dbt deprecations.....................................................Passed
sqlfluff-lint........................................(no files to check)Skipped
[DA-5436-add-pre-commit-hook-dbt-autofix 914c2288] try to commit
 1 file changed, 1 insertion(+), 2 deletions(-)

[shiv-io]

@chayac I have a PR to fix here: #377 would appreciate a review!