Map metric YAML hidden field to is_private and add test

Author: theyostalservice

core/dbt/parser/schema_yaml_readers.py

@@ -508,6 +508,7 @@ def _get_metric_type_params(
                 ),
                 metric_aggregation_params=metric_aggregation_params,
                 join_to_timespine=unparsed_metric.join_to_timespine or False,
+                is_private=unparsed_metric.hidden,
             )
         else:
             raise DbtInternalError(

tests/functional/semantic_models/fixtures.py

@@ -846,6 +846,24 @@
         conversion_metric: simple_metric_2
 """
 
+schema_yml_v2_metrics_with_hidden = """
+    metrics:
+      - name: public_metric
+        description: A metric that is not hidden.
+        label: Public Metric
+        type: simple
+        agg: count
+        expr: id
+        hidden: false
+      - name: private_metric
+        description: A metric that is hidden.
+        label: Private Metric
+        type: simple
+        agg: count
+        expr: id
+        hidden: true
+"""
+
 schema_yml_v2_metric_with_doc_jinja = """
       - name: simple_metric_with_doc_jinja
         description: "{{ doc('simple_metric_description') }}"

tests/functional/semantic_models/test_semantic_model_v2_parsing.py

@@ -20,6 +20,7 @@
     schema_yml_v2_cumulative_metric_missing_input_metric,
     schema_yml_v2_metric_with_doc_jinja,
     schema_yml_v2_metric_with_filter_dimension_jinja,
+    schema_yml_v2_metrics_with_hidden,
     schema_yml_v2_simple_metric_on_model_1,
     schema_yml_v2_standalone_metrics,
     schema_yml_v2_standalone_metrics_with_doc_jinja,
@@ -465,6 +466,32 @@ def test_metric_on_model_parsing(self, project):
         assert conversion_metric_pydantic.type_params.metric_aggregation_params is None
 
 
+class TestMetricHiddenMapsToIsPrivate:
+    """Test that a metric's 'hidden' field in YAML is reflected as 'is_private' on the parsed metric."""
+
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "schema.yml": base_schema_yml_v2 + schema_yml_v2_metrics_with_hidden,
+            "fct_revenue.sql": fct_revenue_sql,
+            "metricflow_time_spine.sql": metricflow_time_spine_sql,
+        }
+
+    def test_metric_hidden_yaml_maps_to_is_private(self, project):
+        runner = dbtTestRunner()
+        result = runner.invoke(["parse"])
+        assert result.success
+        manifest = result.result
+        metrics = manifest.metrics
+        assert len(metrics) == 2
+
+        public_metric = metrics["metric.test.public_metric"]
+        assert public_metric.type_params.is_private is False
+
+        private_metric = metrics["metric.test.private_metric"]
+        assert private_metric.type_params.is_private is True
+
+
 class TestStandaloneMetricParsingSimpleMetricFails:
     @pytest.fixture(scope="class")
     def models(self):