[Bug] Warning about `dataset` that should be under config for sources

[kverburg]

Is this a new bug in dbt-core?

• I believe this is a new bug in dbt-core
• I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

dbt Cloud is current throwing warnings about a dataset key in sources. It warns that it should be under config, but that is not correct I think. dataset is an alias for schema under BIgquery. It does handle the other alias, project (from database), correctly.

Expected Behavior

I dont expect any warnings.

Steps To Reproduce

1. Use a project with BQ
2. Create a source with the dataset key to point to the dataset
3. Run compile/run or any other

Relevant log output

Found `dataset` as a top-level property of `sources[0]` in file
`models/staging/<source>/_source.yml`. The `dataset` top-level property should be
moved into the `config` of `sources[0]`.

Environment

- OS: Macos
- Python: 3.12
- dbt: Platform/latest

Which database adapter are you using with dbt?

bigquery

Additional Context

This bug popped up after a similar one was squashed, this one.

[graciegoheen]

Dang, I thought we squashed this one! I will have the team take a look.

Can you share a code snippet of how you're configuring dataset for your sources?

I wonder if the issue is dataset (aka schema) is a config for models, but a top-level-key for sources.

[kverburg]

Hey @graciegoheen , yep here you go:

version: 2

sources:
- name: hubspot
  project: <redacted>
  dataset: hubspot
  tables:
  - name: contact
    columns:
...

So the weird thing is dat project works fine. Is there something different in how that is set up? As I guess its the same with with models<>sources part?

[alexaustin007]

Hey @graciegoheen do you think you could assign this to me? I can work on it and raise a PR.

[alexaustin007]

Raised a PR since it is open. Requesting to review. Thank You