Skip to content

test(databricks): cover catalog metadata text parity - #15710

Open
sd-db wants to merge 1 commit into
dbt-labs:mainfrom
sd-db:sd-db/port/catalog-metadata-text-fusion
Open

test(databricks): cover catalog metadata text parity#15710
sd-db wants to merge 1 commit into
dbt-labs:mainfrom
sd-db:sd-db/port/catalog-metadata-text-fusion

Conversation

@sd-db

@sd-db sd-db commented Jul 29, 2026

Copy link
Copy Markdown

Resolves #15691

Problem

databricks/dbt-databricks#1428 prevents catalog generation from failing when
metadata from separate schemas receives conflicting agate-inferred types. The
Fusion adapter already represents these fields with Arrow string arrays and
typed Rust strings, but it did not have focused regression coverage for the
same boundary cases.

Solution

Add Databricks metadata adapter tests that verify:

  • numeric-looking table, owner, comment, and column values remain strings;
  • metadata from separate schema record batches aggregates without a
    value-driven type conflict;
  • empty record batches return empty metadata maps without field lookup errors.

No production behavior changes are required because Fusion is already
conformant with the dbt-databricks behavior.

Testing

  • cargo test -p dbt-adapter catalog_metadata_ --lib
    • 3 passed; 0 failed; 874 filtered out

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests.
  • This PR has no interface changes.
  • Type annotations are not applicable because this change adds Rust tests only.

@sd-db
sd-db requested a review from a team as a code owner July 29, 2026 04:33
@cla-bot cla-bot Bot added the cla:yes label Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

codescene-delta-analysis[bot]

This comment was marked as outdated.

@sd-db
sd-db force-pushed the sd-db/port/catalog-metadata-text-fusion branch from 970f105 to 6f09cf1 Compare July 29, 2026 06:47
@sd-db

sd-db commented Jul 29, 2026

Copy link
Copy Markdown
Author

This PR adds test-only parity coverage and does not change user-facing behavior or interfaces. Could a maintainer please apply the Skip Changelog label?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PORT-OVER] fix: prevent agate type-conflict during catalog merge

1 participant