fix: pre-process API response in update_job/create_job return value when use_desc_for_id

When use_desc_for_id=True, the API response has [[id]] in description. Now
update_job and create_job call _pre_process_job_data on the response before
building the returned JobDefinition, matching get_job's existing behavior.

Author: b-per

src/dbt_jobs_as_code/client/__init__.py

@@ -128,7 +128,11 @@ def update_job(self, job: JobDefinition) -> JobDefinition:
         else:
             logger.success("Job updated successfully.")
 
-        return JobDefinition(**(response.json()["data"]), identifier=job.identifier)
+        raw_data = response.json()["data"]
+        if self._use_desc_for_id:
+            raw_data = DBTCloud._pre_process_job_data(raw_data)
+            return JobDefinition(**raw_data)
+        return JobDefinition(**raw_data, identifier=job.identifier)
 
     def create_job(self, job: JobDefinition) -> Optional[JobDefinition]:
         """Create a dbt Cloud Job using a JobDefinition"""
@@ -149,7 +153,11 @@ def create_job(self, job: JobDefinition) -> Optional[JobDefinition]:
         else:
             logger.success("Job created successfully.")
 
-        return JobDefinition(**(response.json()["data"]), identifier=job.identifier)
+        raw_data = response.json()["data"]
+        if self._use_desc_for_id:
+            raw_data = DBTCloud._pre_process_job_data(raw_data)
+            return JobDefinition(**raw_data)
+        return JobDefinition(**raw_data, identifier=job.identifier)
 
     def delete_job(self, job: JobDefinition) -> None:
         """Delete a dbt Cloud job."""

tests/client/test_use_desc_for_id.py

@@ -197,10 +197,11 @@ def test_get_jobs_no_preprocessing_when_flag_off(self):
 class TestUpdateCreateDescMode:
     """Tests that update_job/create_job pass use_desc_for_id to to_payload."""
 
-    def _make_job(self, identifier="daily_job"):
+    def _make_job(self, identifier="daily_job", description="Runs nightly"):
         return JobDefinition(
             id=42,
             name=f"Daily Job [[{identifier}]]",
+            description=description,
             account_id=1,
             project_id=100,
             environment_id=200,
@@ -293,3 +294,33 @@ def capture_post(**kwargs):
         payload = json.loads(captured["data"])
         assert "[[daily_job]]" in payload["name"]
         assert "[[daily_job]]" not in payload["description"]
+
+    def test_update_job_return_value_has_identifier_in_desc_mode(self):
+        """update_job pre-processes the API response so the returned JobDefinition has a clean identifier and description."""
+        client = DBTCloud(account_id=1, api_key="test-key", use_desc_for_id=True)
+        job = self._make_job(description="Runs nightly")
+
+        def mock_post(**kwargs):
+            return self._make_mock_response(job, use_desc_for_id=True)
+
+        client._session.post = mock_post
+        result = client.update_job(job)
+
+        assert result.identifier == "daily_job"
+        assert result.name == "Daily Job"
+        assert result.description == "Runs nightly"
+
+    def test_create_job_return_value_has_identifier_in_desc_mode(self):
+        """create_job pre-processes the API response so the returned JobDefinition has a clean identifier and description."""
+        client = DBTCloud(account_id=1, api_key="test-key", use_desc_for_id=True)
+        job = self._make_job(description="Runs nightly")
+
+        def mock_post(**kwargs):
+            return self._make_mock_response(job, use_desc_for_id=True)
+
+        client._session.post = mock_post
+        result = client.create_job(job)
+
+        assert result.identifier == "daily_job"
+        assert result.name == "Daily Job"
+        assert result.description == "Runs nightly"