Skip to content

fix: strip trailing slashes from base_url and raise on all API errors#194

Merged
b-per merged 1 commit into
mainfrom
fix/single-tenant-base-url
Feb 24, 2026
Merged

fix: strip trailing slashes from base_url and raise on all API errors#194
b-per merged 1 commit into
mainfrom
fix/single-tenant-base-url

Conversation

@b-per
Copy link
Copy Markdown
Collaborator

@b-per b-per commented Feb 24, 2026

Raised from investigating #193

Trailing slashes in DBT_BASE_URL (common with single-tenant instances)
produced double-slash URLs that could be rejected by stricter servers.
Also, _make_request silently swallowed non-401 HTTP errors, returning
an empty job list and causing plan to show CREATE for all jobs.

Closes #193
@github-actions
Copy link
Copy Markdown
Contributor

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/dbt_jobs_as_code
   main.py31016048%120–123, 129, 168–169, 200–203, 209, 245–329, 400–405, 418–419, 437–438, 442–444, 461–510, 539–597, 628–673, 678–679, 683
src/dbt_jobs_as_code/client
   __init__.py1794674%16, 53–54, 62, 99–100, 119–120, 139–140, 155–156, 170–171, 187–188, 205, 215, 295–310, 333, 349–350, 360–372, 375–386, 391–400
src/dbt_jobs_as_code/cloud_yaml_mapping
   change_set.py2353087%27–29, 59, 65–66, 155, 212, 224, 247, 251–252, 258–260, 275–278, 334–348, 401–423, 459–473
src/dbt_jobs_as_code/importer
   __init__.py27774%14–15, 22–27
src/dbt_jobs_as_code/schemas
   __init__.py23291%68, 78
   common_types.py60395%67–68, 91
   config.py14193%18
   job.py130695%227, 232, 248–257
TOTAL118025578% 

Tests Skipped Failures Errors Time
158 0 💤 0 ❌ 0 🔥 14.700s ⏱️

@b-per b-per merged commit ef8de19 into main Feb 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant