fix: validate job description max length of 255 characters#205
Merged
Conversation
The dbt Cloud API silently returns a 500 error when a job description exceeds 255 characters. Add a Pydantic max_length=255 constraint so users get a clear validation error before the API call is made.
Contributor
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
Author
|
CI passed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_length=255to thedescriptionfield onJobDefinition, giving users a clear Pydantic validation error instead of a silent HTTP 500 from the APIload_job_schema.json) withmaxLength: 255Closes #204
Root cause
The dbt Cloud API enforces a 255-character limit on job descriptions but returns a generic 500 error with no useful message. The limit is not documented in the API spec.
Test plan
uv run pytest tests/schemas/test_job.py::TestDescriptionValidation— all 4 tests passuv run pytest— full suite (171 tests) passes