Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changes/unreleased/Under the Hood-20260513-085632.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: Under the Hood
body: Make ToolDefinition.structured_output default to True and require title in generic_dbt_mcp_tool. Decorator now keyword-only.
time: 2026-05-13T08:56:32.224755-05:00
11 changes: 11 additions & 0 deletions src/dbt_mcp/dbt_cli/tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ def get_node_details_dev(
return [
ToolDefinition(
fn=build,
title="dbt build",
description=get_prompt("dbt_cli/build"),
annotations=create_tool_annotations(
title="dbt build",
Expand All @@ -439,6 +440,7 @@ def get_node_details_dev(
),
ToolDefinition(
fn=compile,
title="dbt compile",
description=get_prompt("dbt_cli/compile"),
annotations=create_tool_annotations(
title="dbt compile",
Expand All @@ -449,6 +451,7 @@ def get_node_details_dev(
),
ToolDefinition(
fn=docs,
title="dbt docs",
description=get_prompt("dbt_cli/docs"),
annotations=create_tool_annotations(
title="dbt docs",
Expand All @@ -460,6 +463,7 @@ def get_node_details_dev(
ToolDefinition(
name="list",
fn=ls,
title="dbt list",
description=get_prompt("dbt_cli/list"),
annotations=create_tool_annotations(
title="dbt list",
Expand All @@ -470,6 +474,7 @@ def get_node_details_dev(
),
ToolDefinition(
fn=parse,
title="dbt parse",
description=get_prompt("dbt_cli/parse"),
annotations=create_tool_annotations(
title="dbt parse",
Expand All @@ -480,6 +485,7 @@ def get_node_details_dev(
),
ToolDefinition(
fn=run,
title="dbt run",
description=get_prompt("dbt_cli/run"),
annotations=create_tool_annotations(
title="dbt run",
Expand All @@ -490,6 +496,7 @@ def get_node_details_dev(
),
ToolDefinition(
fn=test,
title="dbt test",
description=get_prompt("dbt_cli/test"),
annotations=create_tool_annotations(
title="dbt test",
Expand All @@ -500,6 +507,7 @@ def get_node_details_dev(
),
ToolDefinition(
fn=show,
title="dbt show",
description=get_prompt("dbt_cli/show"),
annotations=create_tool_annotations(
title="dbt show",
Expand All @@ -510,6 +518,7 @@ def get_node_details_dev(
),
ToolDefinition(
fn=clone,
title="dbt clone",
description=get_prompt("dbt_cli/clone"),
annotations=create_tool_annotations(
title="dbt clone",
Expand All @@ -521,6 +530,7 @@ def get_node_details_dev(
ToolDefinition(
name="get_lineage_dev",
fn=get_lineage_dev,
title="Get Model Lineage (Dev)",
description=get_prompt("dbt_cli/get_lineage_dev"),
annotations=create_tool_annotations(
title="Get Model Lineage (Dev)",
Expand All @@ -532,6 +542,7 @@ def get_node_details_dev(
ToolDefinition(
name="get_node_details_dev",
fn=get_node_details_dev,
title="Get Node Details (Dev)",
description=get_prompt("dbt_cli/get_node_details_dev"),
annotations=create_tool_annotations(
title="Get Node Details (Dev)",
Comment on lines 432 to 548
Expand Down
6 changes: 3 additions & 3 deletions src/dbt_mcp/dbt_codegen/tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,29 +163,29 @@ def generate_staging_model(
return [
ToolDefinition(
fn=generate_source,
title="Generate Source",
description=get_prompt("dbt_codegen/generate_source"),
annotations=create_tool_annotations(
title="dbt-codegen generate_source",
read_only_hint=True,
destructive_hint=False,
idempotent_hint=True,
),
),
ToolDefinition(
fn=generate_model_yaml,
title="Generate Model YAML",
description=get_prompt("dbt_codegen/generate_model_yaml"),
annotations=create_tool_annotations(
title="dbt-codegen generate_model_yaml",
read_only_hint=True,
destructive_hint=False,
idempotent_hint=True,
),
),
ToolDefinition(
fn=generate_staging_model,
title="Generate Staging Model",
description=get_prompt("dbt_codegen/generate_staging_model"),
annotations=create_tool_annotations(
title="dbt-codegen generate_staging_model",
read_only_hint=True,
destructive_hint=False,
idempotent_hint=True,
Expand Down
2 changes: 1 addition & 1 deletion src/dbt_mcp/lsp/tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ async def wrapper(*args, **kwargs) -> Any:
return [
ToolDefinition(
fn=call_with_lsp_client(get_column_lineage),
title="Get Column Lineage",
description=get_prompt("lsp/get_column_lineage"),
annotations=create_tool_annotations(
title="get_column_lineage",
read_only_hint=False,
destructive_hint=False,
idempotent_hint=True,
Expand Down
13 changes: 6 additions & 7 deletions src/dbt_mcp/tools/definitions.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,12 @@
@dataclass
class GenericToolDefinition[NameEnum: Enum]:
fn: Callable[..., Any]
title: str # Human-friendly title for the tool
description: str
name_enum: type[NameEnum]
name: str | None = None
title: str | None = None
name: str | None = None # Machine-friendly name for the tool
annotations: ToolAnnotations | None = None
# We haven't strictly defined our tool contracts yet.
# So we're setting this to False by default for now.
structured_output: bool | None = False
structured_output: bool = True
meta: dict[str, Any] | None = None

def get_name(self) -> NameEnum:
Expand Down Expand Up @@ -62,15 +60,16 @@ class ToolDefinition(GenericToolDefinition[ToolName]):


def generic_dbt_mcp_tool[NameEnum: Enum](
*,
description: str,
title: str,
name_enum: type[NameEnum],
name: str | None = None,
title: str | None = None,
read_only_hint: bool = False,
destructive_hint: bool = True,
idempotent_hint: bool = False,
open_world_hint: bool = True,
structured_output: bool | None = False,
structured_output: bool = True,
meta: dict[str, Any] | None = None,
) -> Callable[[Callable], GenericToolDefinition[NameEnum]]:
Comment thread
DevonFulcher marked this conversation as resolved.
"""Decorator to define a tool definition for dbt MCP"""
Expand Down
Loading