Skip to content

Commit 9108bfe

Browse files
committed
Fix metrics ingestion and add test
1 parent 594f799 commit 9108bfe

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

integration_tests/models/marts/metrics.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,6 @@ metrics:
3434
type: simple
3535
type_params:
3636
# Specify the measure you are creating a proxy for.
37-
measure: total_count
37+
measure: total_count
38+
filter: |
39+
{{ Dimension('dim__id') }} > 0

macros/unpack/get_metric_values.sql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@
2020
wrap_string_with_quotes(node.type),
2121
wrap_string_with_quotes(dbt.escape_single_quotes(node.label)),
2222
wrap_string_with_quotes(node.package_name),
23-
wrap_string_with_quotes(node.filter),
23+
wrap_string_with_quotes(node.filter | tojson),
2424
wrap_string_with_quotes(node.type_params.measure.name),
2525
wrap_string_with_quotes(node.type_params.measure.alias),
26-
wrap_string_with_quotes(node.type_params.numerator),
27-
wrap_string_with_quotes(node.type_params.denominator),
26+
wrap_string_with_quotes(node.type_params.numerator | tojson),
27+
wrap_string_with_quotes(node.type_params.denominator | tojson),
2828
wrap_string_with_quotes(node.type_params.expr),
2929
wrap_string_with_quotes(node.type_params.window),
3030
wrap_string_with_quotes(node.type_params.grain_to_date),

0 commit comments

Comments
 (0)