T-SQL support

[sdebruyn]

I would like to have support for dbt-sqlserver and dbt-synapse. What would I have to do to make this happen? I am one of the maintainers of those 2 adapters :)

Update: added support for dbt-fabric #576 and those other adapters inherit from that so this PR kills 3 birds with 1 stone

[dave-connors-3]

hey @sdebruyn! what a wonderful question! apologies for the delay on the response.

I honestly am not sure what the answer is! Given that the team who built this has really limited experience with either of those adapters, i'm not sure how well we'd be able to maintain it. Would hate to not be able to let other users use the package though!

what are your thoughts here?

[b-per]

Hi @sdebruyn ! We have not tested the package on T-SQL and I don't know if it would work or not (feel free to try! 😄 )

The first steps will be to make the dispatched macros work with T-SQL. The main ones are:

• select_from_values()
• recursive_dag()
• cross_db_shims

Saying so, it is not sure that once you get a TSQL version of all those macros the package will work out of the box. I believe that we are using a lof of group by 1, 2 etc... in our models, which to my knowledge is still not supported by Microsoft.

[github-actions]

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

[github-actions]

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

[b-per]

Hi @sdebruyn . We are adding support to more adapters and are keen to revisit this issue. I searched a bit online and kind of saw that group by 1, 2 might be supported in T-SQL now?

Would you still be interested in adding support for TSQL?

To see what would need to be changed you could start with running the integration tests with a profile pointing to a TSQL DW

[github-actions]

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

[jj12000]

+1 to this feature, I would be interested in this package having support for T-SQL, thanks!

[joshrodgersKA]

+1 as well. We are on dbt-fabric now and this would be super useful.