Skip to content

fix: nest generic test arguments under arguments in integration tests#570

Closed
shauneccles wants to merge 1 commit into
dbt-labs:mainfrom
shauneccles:fix/integration-test-arguments-deprecation
Closed

fix: nest generic test arguments under arguments in integration tests#570
shauneccles wants to merge 1 commit into
dbt-labs:mainfrom
shauneccles:fix/integration-test-arguments-deprecation

Conversation

@shauneccles
Copy link
Copy Markdown

Summary

  • The shipped models/ YAML files were already fixed in 78d73ea, but the integration test YAML files were missed
  • Nests generic test parameters under arguments: in core.yml and graph.yml to resolve MissingArgumentsPropertyInGenericTestDeprecation on dbt-core >= 1.11
  • Fixes 4 instances: dbt_utils.expression_is_true, dbt_utils.unique_combination_of_columns, and accepted_values (×2)

Closes #569

Test plan

  • CI passes on dbt-core >= 1.11 without MissingArgumentsPropertyInGenericTestDeprecation warnings
  • Integration tests still pass with the updated YAML structure

🤖 Generated with Claude Code

The shipped models were fixed in 78d73ea but the integration test YAML
files were missed, causing MissingArgumentsPropertyInGenericTestDeprecation
warnings on dbt-core >= 1.11.

Closes dbt-labs#569

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@b-per
Copy link
Copy Markdown
Collaborator

b-per commented Mar 20, 2026

Thanks! I will have a look. I am just wondering how we got the integration tests to pass on Fusion without this being implemented 🤔

@b-per
Copy link
Copy Markdown
Collaborator

b-per commented Mar 24, 2026

I dug further. The reason that Fusion was not raising issues in the past was because those tests were entirely skipped.

The package adds models from the upstream package in its own YAML which is supported in dbt Core but not in Fusion. We need to revisit the whole testing approach to avoid this discrepancy.

I will close this PR to work on an alternative approach and keep the issue opened.

@b-per b-per closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MissingArgumentsPropertyInGenericTestDeprecation in integration test YAML files

2 participants