fix: enable Fusion workflow for fork PRs#563
Merged
Merged
Conversation
Change from `pull_request` to `pull_request_target` so that fork PRs have access to repository variables (like SNOWFLAKE_DATABASE). This aligns with how ci.yml handles fork PRs. The workflow definition still comes from the base branch for security, and we explicitly checkout the PR head for testing.
b-per
requested review from
a team,
dave-connors-3 and
graciegoheen
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_requesttopull_request_targetso fork PRs have access to repository variablespull_request_target)Problem
Fork PRs (like #525) fail the Fusion integration tests because
pull_requestevent doesn't have access to repository variables (vars.SNOWFLAKE_DATABASE, etc.), resulting in:Solution
Use
pull_request_targetinstead, which is the same approach already used byci.ymlfor Package Integration Tests. Maintainer approval is required before workflows run on fork PRs.