fix: nest generic test arguments under arguments in integration tests#570
Closed
shauneccles wants to merge 1 commit into
Closed
fix: nest generic test arguments under arguments in integration tests#570shauneccles wants to merge 1 commit into
arguments in integration tests#570shauneccles wants to merge 1 commit into
Conversation
The shipped models were fixed in 78d73ea but the integration test YAML files were missed, causing MissingArgumentsPropertyInGenericTestDeprecation warnings on dbt-core >= 1.11. Closes dbt-labs#569 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
Thanks! I will have a look. I am just wondering how we got the integration tests to pass on Fusion without this being implemented 🤔 |
Collaborator
|
I dug further. The reason that Fusion was not raising issues in the past was because those tests were entirely skipped. The package adds models from the upstream package in its own YAML which is supported in dbt Core but not in Fusion. We need to revisit the whole testing approach to avoid this discrepancy. I will close this PR to work on an alternative approach and keep the issue opened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
models/YAML files were already fixed in 78d73ea, but the integration test YAML files were missedarguments:incore.ymlandgraph.ymlto resolveMissingArgumentsPropertyInGenericTestDeprecationon dbt-core >= 1.11dbt_utils.expression_is_true,dbt_utils.unique_combination_of_columns, andaccepted_values(×2)Closes #569
Test plan
MissingArgumentsPropertyInGenericTestDeprecationwarnings🤖 Generated with Claude Code