feat: support dbt latest semantic layer spec#573
Merged
Conversation
- Fix get_metric_values.sql to handle null type_params.measure and cumulative_type_params in the new SL spec (metrics embedded in models instead of top-level semantic_models) - Add integration_tests_sl project: copy of integration_tests migrated to the latest SL YAML spec via dbt-autofix --semantic-layer - Run integration_tests_sl as a third project in run_fusion_tests.sh - Add dbt_integration_fusion_duckdb tox env and restructure fusion.yml to run DuckDB tests first, then cloud (Snowflake) only if DuckDB passes
b-per
requested review from
a team,
dave-connors-3 and
graciegoheen
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_metric_values.sqlto handle the new dbt SL spec wheretype_params.measureandtype_params.cumulative_type_paramsarenull(metrics are now embedded directly in models rather than referencing named measures via top-levelsemantic_models)integration_tests_sl: a copy ofintegration_testsmigrated to the latest SL YAML spec viauvx dbt-autofix deprecations --semantic-layerintegration_tests_slas a third project inrun_fusion_tests.sh(with a separate Snowflake schema suffix_slto avoid naming collisions)fusion.ymlinto two jobs:run-duckdb-tests(runs first, no credentials needed) andrun-cloud-tests(needs: run-duckdb-tests), so Snowflake only runs if DuckDB passesdbt_integration_fusion_duckdbtox envTest plan
run-duckdb-testsjob passes on CI (covers all 3 integration test projects with DuckDB)run-cloud-testsjob only triggers after DuckDB passesstg_metricsbuilds successfully inintegration_tests_slwith the new SL spec