ci: use reusable workflows from dbt-labs/dbt-package-testing@v2#574
Merged
Conversation
Switch ci.yml and fusion.yml to call the shared reusable workflows (run_tox.yml and run_tox_fusion.yml) instead of inlining the matrix, checkout, and tox setup steps. Preserves existing schema names, secret mappings, and the pull_request_target fork-PR environment gate.
b-per
requested review from
a team,
dave-connors-3 and
graciegoheen
as code owners
Fusion mis-resolves the path to the package's `dbt_project_evaluator_exceptions` seed when running `dbt seed` from a consuming project, producing a doubled `dbt_packages/dbt_project_evaluator/dbt_packages/dbt_project_evaluator/seeds/...` prefix and failing with an IO error. The seed isn't required here: integration_tests_2 only runs `dbt run` (not `dbt build`), so the on-run-end filter macro that reads the exceptions seed is never invoked.
The SL migration added a date_day time dimension to dim_model_7's YAML but never projected the column in the SQL and never set its data_type. Fusion's strict contract check fails on both counts. Emit a date literal as date_day in the SELECT and declare `data_type: date` in the YAML.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.ymlandfusion.ymlwith calls to the reusable workflowsrun_tox.yml@v2andrun_tox_fusion.yml@v2from dbt-labs/dbt-package-testing.dbt_project_evaluator_integration_tests_snowflake_...,dpe_integration_tests_bigquery_..., etc.) and secret mappings (SNOWFLAKE_PASS→DBT_ENV_SECRET_SNOWFLAKE_PASS,REDSHIFT_PASS→DBT_ENV_SECRET_REDSHIFT_PASS).run-duckdb-testsFusion job as a quick credential-free check that gates the cloud Fusion job.pull_request_target+cloud-testsenvironment gating for fork PRs and PR-head checkout behavior.The project previously referenced this reusable workflow but it was not functioning (couldn't use
pull_request_target); the upstream reusable workflow has since been updated to support that trigger.Test plan
cloud-testsenvironment approval gate