fix: move Fusion DuckDB tests off pull_request_target to safe trigger#578
Merged
Conversation
The run-duckdb-tests job in fusion.yml used pull_request_target (base repo context + secrets) while checking out and executing fork PR code without an environment approval gate — a classic pwn-request vector. Move the Fusion + DuckDB job into local_only.yml which uses the safe pull_request trigger. Remove the now-unnecessary run-duckdb-tests job from fusion.yml and drop the needs: dependency from fusion-tests (the Snowflake cloud job is already gated by the cloud-tests environment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-duckdb-testsjob infusion.ymlusedpull_request_target(runs in base repo context) while checking out and executing fork PR code with no environment approval gate — a classic pwn-request vulnerabilitylocal_only.yml, which uses the safepull_requesttrigger (no base repo context, no secrets)run-duckdb-testsfromfusion.ymland dropped theneeds:dependency fromfusion-tests(the Snowflake cloud job is already gated by thecloud-testsenvironment for fork PRs)tox.inito point to the new homeTest plan
Package Integration Tests - Local Onlyworkflow runs the newrun-fusion-duckdb-testsjob on this PRFusion Integration Testsworkflow no longer shows arun-duckdb-testsjobfusion-tests(Snowflake) still requires environment approval for fork PRs