Merge pull request #57 from dbt-labs/hotfix__divide_by_zero_and_allowlist

Fixing Division By Zero and Allowing Expression Secondary Calculations

Author: callum-mcdata

integration_tests/dbt_project.yml

@@ -21,6 +21,11 @@ clean-targets:
   - "dbt_packages"
   - "logs"
 
+models:
+  dbt_metrics_integration_tests:
+    metric_testing_models:
+      +materialized: table
+
 vars:
   dbt_metrics_calendar_model: custom_calendar
   testing: fact_orders

integration_tests/models/metric_definitions/expression_metric.yml

@@ -7,6 +7,16 @@ metrics:
     time_grains: [day, week]
     type: expression
     sql: "{{metric('base_sum_metric')}} - {{metric('base_average_metric')}}"
+    dimensions:
+      - had_discount
+      - order_country
+
+  - name: ratio_metric
+    label: Ratio ($)
+    timestamp: order_date
+    time_grains: [day, week]
+    type: expression
+    sql: "{{metric('base_sum_metric')}} / {{metric('base_average_metric')}}"
     dimensions:
       - had_discount
       - order_country

integration_tests/models/metric_testing_models/expression_metric__secondary_calculations.sql

@@ -0,0 +1,8 @@
+  select *
+  from 
+  {{ metrics.calculate(
+      metric('ratio_metric'), 
+      grain='day', 
+      dimensions=['had_discount']
+      )
+  }}

integration_tests/models/metric_testing_models/multiple_metrics__period_over_period.sql

@@ -1,4 +1,3 @@
-with metric as (
   select *
   from 
   {{ metrics.calculate(
@@ -10,16 +9,4 @@ with metric as (
         {"calculation": "period_over_period", "interval": 1, "comparison_strategy": "ratio"},
       ] 
       )
-  }}
-)
-
-select 
-  date_day
-  ,had_discount
-  ,base_sum_metric
-  ,cast(base_average_metric as float) as base_average_metric
-  ,base_sum_metric_pop_1mth
-  ,cast(base_sum_metric_ratio_to_1_day_ago as float) as base_sum_metric_ratio_to_1_day_ago
-  ,cast(base_average_metric_pop_1mth as float) as base_average_metric_pop_1mth
-  ,cast(base_average_metric_ratio_to_1_day_ago as float) as base_average_metric_ratio_to_1_day_ago
-from metric 
+  }}

integration_tests/models/metric_testing_models/ratio_metric.sql

@@ -0,0 +1,9 @@
+select *
+from 
+{{ metrics.calculate(
+    metric('ratio_metric'), 
+    grain='day', 
+    dimensions=['had_discount','order_country','is_weekend'],
+    start_date = '2022-01-01',
+    end_date = '2022-01-10') 
+}}