Increase lease timeout for sso operations and provide arrow-adbc configuration hook for future adjustments#13
Merged
Conversation
felipecrv
requested changes
Aug 22, 2025
VersusFacit
commented
Sep 3, 2025
VersusFacit
changed the title
felipecrv
reviewed
Sep 3, 2025
Collaborator
felipecrv
left a comment
felipecrv
left a comment
There was a problem hiding this comment.
Other than the bit-width and time-unit choice. This is perfect!
No need to worry about cpu alignment. single entrypoint to value through setter and getter normalizes. Decisions on how to handle data made explicit for future readers.
Author
|
@felipecrv cool suggestion I got down a rabbit hole on cpu bit alignment :D Made the strategies for handling the timeout explicit in comments. |
felipecrv
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was not enough time to support users doing copy-paste managed SSO for
externalbrowsermethod leading to seemingly no-cache behavior because auth threads kept jumping the line and grabbing the cachefile early.Other tooling like extensions and IDEs will similarly benefit due to overhead that makes this process longer than the automatic browser-based sso. In graphical tools, this can look like the dreaded "multiple tabs" problem.