Actually cancel statements#29
Merged
Merged
Conversation
serramatutu
force-pushed
the
serramatutu/cancel
branch
from
e099145 to
0a6a4da
Compare
felipecrv
approved these changes
May 19, 2026
Collaborator
felipecrv
left a comment
felipecrv
left a comment
There was a problem hiding this comment.
Can you report this upstream also?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use
errors.Is(err, context.Canceled)instead oferr == context.CanceledWhy
It looks like the Go standard library rewrites all errors as a
url.Error, includingcontext.Canceledandcontext.DeadlineExceeded.httpClient.dowraps the returned error into aurl.ErrorThis was making the upstream check for
context.Canceledorcontext.DeadlineExceededfail since it uses strict equality, so thegosnowflakelogic that issues the cancellation request never gets executed.My commit replaces this with
errors.Isinstead.Testing
I ran Fusion with driver debug logs enabled. After my change, you can see the client actually call
cancelQuery.You can see the statement now shows as actually canceled in the Snowflake dashboard