Skip to content

GitHub Dark and Light mode hash fragments not being respected #2476

@DVAlexHiggs

Description

@DVAlexHiggs

We've recently updated our GitHub page with a different logo for light and dark mode, so that our logo is legible regardless of the appearance the user has selected.

Unfortunately, dbt Hub does not account for this and displays both, please see below:

image

Please see here for the live version

The code in our README looks like this:

  <img src="https://user-images.githubusercontent.com/25080503/237990810-ab2e14cf-a449-47ac-8c72-6f0857816194.png#gh-light-mode-only" alt="AutomateDV">
  <img src="https://user-images.githubusercontent.com/25080503/237990915-6afbeba8-9e80-44cb-a57b-5b5966ab5c02.png#gh-dark-mode-only" alt="AutomateDV">

Here are the Github Docs on this feature

Is there any way to enable support for this on dbt Hub? I imagine it might be as simple as adding some CSS to the stylesheets.

I think, as the dbt Hub theme has a white background and this cannot be user-configured, we'd only want to show the gh-light-mode-only image.

Thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions