add tests

Author: Gary James

docs/data-sources/dbt_cloud_environment.md

@@ -17,17 +17,21 @@ description: |-
 
 ### Required
 
-- **dbt_version** (String) Version number of dbt to use in this environment
-- **name** (String) Environment name
+- **environment_id** (Number) Project ID to create the environment in
 - **project_id** (Number) Project ID to create the environment in
-- **type** (String) The type of environment (must be either development or deployment)
 
 ### Optional
 
+- **id** (String) The ID of this resource.
+
+### Read-Only
+
 - **credential_id** (Number) Credential ID to create the environment with
 - **custom_branch** (String) Which custom branch to use in this environment
-- **id** (String) The ID of this resource.
+- **dbt_version** (String) Version number of dbt to use in this environment
 - **is_active** (Boolean) Whether the environment is active
+- **name** (String) Environment name
+- **type** (String) The type of environment (must be either development or deployment)
 - **use_custom_branch** (Boolean) Whether to use a custom git branch in this environment
 
 

docs/data-sources/dbt_cloud_snowflake_credential.md

@@ -17,16 +17,20 @@ description: |-
 
 ### Required
 
-- **auth_type** (String) The type of Snowflake credential ('password' only currently supported in Terraform)
-- **num_threads** (Number) Number of threads to use
-- **password** (String, Sensitive) Password for Snowflake
-- **project_id** (Number) Project ID to create the Snowflake credential in
-- **schema** (String) Default schema name
-- **user** (String) Username for Snowflake
+- **credential_id** (Number) Credential ID
+- **project_id** (Number) Project ID
 
 ### Optional
 
 - **id** (String) The ID of this resource.
+
+### Read-Only
+
+- **auth_type** (String) The type of Snowflake credential ('password' only currently supported in Terraform)
 - **is_active** (Boolean) Whether the Snowflake credential is active
+- **num_threads** (Number) Number of threads to use
+- **password** (String, Sensitive) Password for Snowflake
+- **schema** (String) Default schema name
+- **user** (String) Username for Snowflake
 
 

pkg/data_sources/environment.go

@@ -10,36 +10,39 @@ import (
 )
 
 var environmentSchema = map[string]*schema.Schema{
-	"is_active": &schema.Schema{
-		Type:        schema.TypeBool,
-		Optional:    true,
-		Default:     true,
-		Description: "Whether the environment is active",
+	"environment_id": &schema.Schema{
+		Type:        schema.TypeInt,
+		Required:    true,
+		Description: "Project ID to create the environment in",
 	},
 	"project_id": &schema.Schema{
 		Type:        schema.TypeInt,
 		Required:    true,
 		Description: "Project ID to create the environment in",
 	},
+	"is_active": &schema.Schema{
+		Type:        schema.TypeBool,
+		Computed:    true,
+		Description: "Whether the environment is active",
+	},
 	"credential_id": &schema.Schema{
 		Type:        schema.TypeInt,
-		Optional:    true,
-		Default:     nil,
+		Computed:    true,
 		Description: "Credential ID to create the environment with",
 	},
 	"name": &schema.Schema{
 		Type:        schema.TypeString,
-		Required:    true,
+		Computed:    true,
 		Description: "Environment name",
 	},
 	"dbt_version": &schema.Schema{
 		Type:        schema.TypeString,
-		Required:    true,
+		Computed:    true,
 		Description: "Version number of dbt to use in this environment",
 	},
 	"type": &schema.Schema{
 		Type:        schema.TypeString,
-		Required:    true,
+		Computed:    true,
 		Description: "The type of environment (must be either development or deployment)",
 		ValidateFunc: func(val interface{}, key string) (warns []string, errs []error) {
 			type_ := val.(string)
@@ -55,14 +58,12 @@ var environmentSchema = map[string]*schema.Schema{
 	},
 	"use_custom_branch": &schema.Schema{
 		Type:        schema.TypeBool,
-		Optional:    true,
-		Default:     false,
+		Computed:    true,
 		Description: "Whether to use a custom git branch in this environment",
 	},
 	"custom_branch": &schema.Schema{
 		Type:        schema.TypeString,
-		Optional:    true,
-		Default:     "",
+		Computed:    true,
 		Description: "Which custom branch to use in this environment",
 	},
 }

pkg/data_sources/environment_test.go

@@ -0,0 +1,45 @@
+package data_sources_test
+
+import (
+	"fmt"
+	"strconv"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+)
+
+func TestAccDbtCloudEnvironmentDataSource(t *testing.T) {
+
+	randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum)
+	randomIDInt, _ := strconv.Atoi(randomID)
+
+	config := fmt.Sprintf(`
+			data "dbt_cloud_environment" "test" {
+				project_id = 123
+				environment_id = %d
+			}
+		`, randomIDInt)
+
+	check := resource.ComposeAggregateTestCheckFunc(
+		resource.TestCheckResourceAttr("data.dbt_cloud_environment.test", "environment_id", randomID),
+		resource.TestCheckResourceAttr("data.dbt_cloud_environment.test", "project_id", "123"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_project.test", "name"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_project.test", "is_active"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_project.test", "credential_id"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_project.test", "dbt_version"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_project.test", "type"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_project.test", "use_custom_branch"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_project.test", "custom_branch"),
+	)
+
+	resource.ParallelTest(t, resource.TestCase{
+		Providers: providers(),
+		Steps: []resource.TestStep{
+			{
+				Config: config,
+				Check:  check,
+			},
+		},
+	})
+}

pkg/data_sources/snowflake_credential.go

@@ -10,20 +10,24 @@ import (
 )
 
 var snowflakeCredentialSchema = map[string]*schema.Schema{
-	"is_active": &schema.Schema{
-		Type:        schema.TypeBool,
-		Optional:    true,
-		Default:     true,
-		Description: "Whether the Snowflake credential is active",
-	},
 	"project_id": &schema.Schema{
 		Type:        schema.TypeInt,
 		Required:    true,
-		Description: "Project ID to create the Snowflake credential in",
+		Description: "Project ID",
+	},
+	"credential_id": &schema.Schema{
+		Type:        schema.TypeInt,
+		Required:    true,
+		Description: "Credential ID",
+	},
+	"is_active": &schema.Schema{
+		Type:        schema.TypeBool,
+		Computed:    true,
+		Description: "Whether the Snowflake credential is active",
 	},
 	"auth_type": &schema.Schema{
 		Type:        schema.TypeString,
-		Required:    true,
+		Computed:    true,
 		Description: "The type of Snowflake credential ('password' only currently supported in Terraform)",
 		ValidateFunc: func(val interface{}, key string) (warns []string, errs []error) {
 			type_ := val.(string)
@@ -38,23 +42,23 @@ var snowflakeCredentialSchema = map[string]*schema.Schema{
 	},
 	"schema": &schema.Schema{
 		Type:        schema.TypeString,
-		Required:    true,
+		Computed:    true,
 		Description: "Default schema name",
 	},
 	"user": &schema.Schema{
 		Type:        schema.TypeString,
-		Required:    true,
+		Computed:    true,
 		Description: "Username for Snowflake",
 	},
 	"password": &schema.Schema{
 		Type:        schema.TypeString,
-		Required:    true,
+		Computed:    true,
 		Sensitive:   true,
 		Description: "Password for Snowflake",
 	},
 	"num_threads": &schema.Schema{
 		Type:        schema.TypeInt,
-		Required:    true,
+		Computed:    true,
 		Description: "Number of threads to use",
 	},
 	// TODO: add private_key and private_key_passphrase

pkg/data_sources/snowflake_credential_test.go

@@ -0,0 +1,44 @@
+package data_sources_test
+
+import (
+	"fmt"
+	"strconv"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+)
+
+func TestAccDbtCloudSnowflakeCredentialDataSource(t *testing.T) {
+
+	randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum)
+	randomIDInt, _ := strconv.Atoi(randomID)
+
+	config := fmt.Sprintf(`
+			data "dbt_cloud_snowflake_credential" "test" {
+				project_id = 123
+				credential_id = %d
+			}
+		`, randomIDInt)
+
+	check := resource.ComposeAggregateTestCheckFunc(
+		resource.TestCheckResourceAttr("data.dbt_cloud_snowflake_credential.test", "credential_id", randomID),
+		resource.TestCheckResourceAttr("data.dbt_cloud_snowflake_credential.test", "project_id", "123"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_snowflake_credential.test", "auth_type"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_snowflake_credential.test", "is_active"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_snowflake_credential.test", "schema"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_snowflake_credential.test", "user"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_snowflake_credential.test", "password"),
+		resource.TestCheckResourceAttrSet("data.dbt_cloud_snowflake_credential.test", "num_threads"),
+	)
+
+	resource.ParallelTest(t, resource.TestCase{
+		Providers: providers(),
+		Steps: []resource.TestStep{
+			{
+				Config: config,
+				Check:  check,
+			},
+		},
+	})
+}