Remove isolation of conformance tests

Author: victorasu

Makefile

@@ -23,9 +23,6 @@ test: deps
 test-acceptance: deps
 	TF_ACC=1 go test -v -mod=readonly -count=1 -p 1 -parallel 10 ./...
 
-test-conformance: deps
-	TF_ACC=1 go test -v -short -mod=readonly -count=1 -p 1 -parallel 10 ./...
-
 check-docs: doc
 	git diff --exit-code -- docs
 

pkg/framework/objects/repository/resource_acceptance_test.go

@@ -106,28 +106,23 @@ func TestAccDbtCloudRepositoryResource(t *testing.T) {
 		},
 	})
 
-	// This could be done in the opposite way, where running with 'go test -short' would skip
-	// the conformance tests. However, we should aim to only run conformance tests when we need to
-	if testing.Short() {
-		t.Log("Running conformance tests")
-		resource.Test(t, resource.TestCase{
-			PreCheck:     func() { acctest_helper.TestAccPreCheck(t) },
-			CheckDestroy: testAccCheckDbtCloudRepositoryDestroy,
-			Steps: []resource.TestStep{
-				acctest_helper.MakeExternalProviderTestStep(createByDeployKeyTestStep, acctest_config.LAST_VERSION_BEFORE_FRAMEWORK_MIGRATION),
-				acctest_helper.MakeCurrentProviderNoOpTestStep(createByDeployKeyTestStep),
-			},
-		})
-
-		resource.Test(t, resource.TestCase{
-			PreCheck:     func() { acctest_helper.TestAccPreCheck(t) },
-			CheckDestroy: testAccCheckDbtCloudRepositoryDestroy,
-			Steps: []resource.TestStep{
-				acctest_helper.MakeExternalProviderTestStep(createByCloneTestStep, acctest_config.LAST_VERSION_BEFORE_FRAMEWORK_MIGRATION),
-				acctest_helper.MakeCurrentProviderNoOpTestStep(createByCloneTestStep),
-			},
-		})
-	}
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { acctest_helper.TestAccPreCheck(t) },
+		CheckDestroy: testAccCheckDbtCloudRepositoryDestroy,
+		Steps: []resource.TestStep{
+			acctest_helper.MakeExternalProviderTestStep(createByDeployKeyTestStep, acctest_config.LAST_VERSION_BEFORE_FRAMEWORK_MIGRATION),
+			acctest_helper.MakeCurrentProviderNoOpTestStep(createByDeployKeyTestStep),
+		},
+	})
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { acctest_helper.TestAccPreCheck(t) },
+		CheckDestroy: testAccCheckDbtCloudRepositoryDestroy,
+		Steps: []resource.TestStep{
+			acctest_helper.MakeExternalProviderTestStep(createByCloneTestStep, acctest_config.LAST_VERSION_BEFORE_FRAMEWORK_MIGRATION),
+			acctest_helper.MakeCurrentProviderNoOpTestStep(createByCloneTestStep),
+		},
+	})
 }
 
 func testAccDbtCloudRepositoryResourceGithubConfig(repoUrl, projectName string) string {