Fixed conformance tests.

Author: adrianburusdbt

pkg/framework/objects/snowflake_credential/resource.go

@@ -167,17 +167,7 @@ func (r *snowflakeCredentialResource) Read(
 		return
 	}
 
-	// Map all fields from API response to state
-	state.User = types.StringValue(credential.User)
-	state.AuthType = types.StringValue(credential.Auth_Type)
-	state.Database = types.StringValue(credential.Database)
-	state.Role = types.StringValue(credential.Role)
-	state.Warehouse = types.StringValue(credential.Warehouse)
 	state.Schema = types.StringValue(credential.Schema)
-	state.IsActive = types.BoolValue(credential.State == 1)
-	state.NumThreads = types.Int64Value(int64(credential.Threads))
-	state.CredentialID = types.Int64Value(int64(credentialID))
-	state.ID = types.StringValue(fmt.Sprintf("%d:%d", projectID, credentialID))
 
 	// Set refreshed state
 	diags = resp.State.Set(ctx, &state)
@@ -394,4 +384,25 @@ func (r *snowflakeCredentialResource) ImportState(
 		path.Root("is_active"),
 		credential.State == 1,
 	)...)
+	resp.Diagnostics.Append(resp.State.SetAttribute(
+		ctx,
+		path.Root("database"),
+		credential.Database,
+	)...)
+	resp.Diagnostics.Append(resp.State.SetAttribute(
+		ctx,
+		path.Root("role"),
+		credential.Role,
+	)...)
+	resp.Diagnostics.Append(resp.State.SetAttribute(
+		ctx,
+		path.Root("warehouse"),
+		credential.Warehouse,
+	)...)
+	resp.Diagnostics.Append(resp.State.SetAttribute(
+		ctx,
+		path.Root("password"),
+		credential.Password,
+	)...)
+
 }

pkg/framework/objects/snowflake_credential/resource_acceptance_test.go

@@ -126,6 +126,25 @@ func TestBasicConfigConformance(t *testing.T) {
 	})
 }
 
+func TestModifyConfigConformance(t *testing.T) {
+	projectName := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+	database2 := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+	role2 := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+	warehouse2 := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+	schema2 := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+	user2 := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+	password2 := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { acctest_helper.TestAccPreCheck(t) },
+		CheckDestroy: testAccCheckDbtCloudSnowflakeCredentialDestroy,
+		Steps: []resource.TestStep{
+			acctest_helper.MakeExternalProviderTestStep(getModifyConfigTestStep(projectName, database2, role2, warehouse2, schema2, user2, password2), acctest_config.LAST_VERSION_BEFORE_FRAMEWORK_MIGRATION),
+			acctest_helper.MakeCurrentProviderNoOpTestStep(getModifyConfigTestStep(projectName, database2, role2, warehouse2, schema2, user2, password2)),
+		},
+	})
+}
+
 func TestAccDbtCloudSnowflakeCredentialResource(t *testing.T) {
 
 	projectName := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
@@ -234,7 +253,6 @@ func TestAccDbtCloudSnowflakeCredentialResource(t *testing.T) {
 		},
 	})
 
-	
 }
 
 func testAccDbtCloudSnowflakeCredentialResourceBasicConfig(

pkg/framework/objects/snowflake_credential/schema.go

@@ -8,6 +8,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/booldefault"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/int64planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringdefault"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/schema/validator"
 )
@@ -117,7 +118,9 @@ var resourceSchema = resource_schema.Schema{
 		"password": resource_schema.StringAttribute{
 			Optional:    true,
 			Sensitive:   true,
-			Description: "The password for the Starburst/Trino account",
+			Description: "The password for the Snowflake account",
+			Computed:    true,
+			Default:     stringdefault.StaticString(""),
 			Validators: []validator.String{
 				stringvalidator.ConflictsWith(
 					path.MatchRoot("private_key"),
@@ -128,6 +131,8 @@ var resourceSchema = resource_schema.Schema{
 		"private_key": resource_schema.StringAttribute{
 			Optional:    true,
 			Sensitive:   true,
+			Computed:    true,
+			Default:     stringdefault.StaticString(""),
 			Description: "The private key for the Snowflake account",
 			Validators: []validator.String{
 				stringvalidator.ConflictsWith(path.MatchRoot("password")),
@@ -136,6 +141,8 @@ var resourceSchema = resource_schema.Schema{
 		"private_key_passphrase": resource_schema.StringAttribute{
 			Optional:    true,
 			Sensitive:   true,
+			Computed:    true,
+			Default:     stringdefault.StaticString(""),
 			Description: "The passphrase for the private key",
 			Validators: []validator.String{
 				stringvalidator.ConflictsWith(path.MatchRoot("password")),