Migrate job resource sign 54 (#383)

* Add basic foundation for the migration

* Add basic conformance test

* Add resource model

* Add schema implementation

* Make doc and validate the differences

* Add read resource

* Add delete method

* Add create method

* Add update method

* Add missing code from sdkv2

* Add incremental changes for job tests

* Add schema fixes

* Going over changed code

* Remove call to read method

* Basic tests are passing

* Progress on testing

* Update doc

* Add conformance tests

* Remove from sdk provider

* Add more conformance tests

Author: vladmld

docs/resources/job.md

@@ -2,7 +2,7 @@
 page_title: "dbtcloud_job Resource - dbtcloud"
 subcategory: ""
 description: |-
-  
+  Managed a dbt Cloud job.
 ---
 
 # dbtcloud_job (Resource)
@@ -112,7 +112,7 @@ resource "dbtcloud_job" "downstream_job" {
 - `execute_steps` (List of String) List of commands to execute for the job
 - `name` (String) Job name
 - `project_id` (Number) Project ID to create the job in
-- `triggers` (Map of Boolean) Flags for which types of triggers to use, the values are `github_webhook`, `git_provider_webhook`, `schedule` and `on_merge`. All flags should be listed and set with `true` or `false`. When `on_merge` is `true`, all the other values must be false.<br>`custom_branch_only` used to be allowed but has been deprecated from the API. The jobs will use the custom branch of the environment. Please remove the `custom_branch_only` from your config. <br>To create a job in a 'deactivated' state, set all to `false`.
+- `triggers` (Attributes) Flags for which types of triggers to use, the values are `github_webhook`, `git_provider_webhook`, `schedule` and `on_merge`. All flags should be listed and set with `true` or `false`. When `on_merge` is `true`, all the other values must be false.<br>`custom_branch_only` used to be allowed but has been deprecated from the API. The jobs will use the custom branch of the environment. Please remove the `custom_branch_only` from your config. <br>To create a job in a 'deactivated' state, set all to `false`. (see [below for nested schema](#nestedatt--triggers))
 
 ### Optional
 
@@ -124,7 +124,7 @@ resource "dbtcloud_job" "downstream_job" {
 - `errors_on_lint_failure` (Boolean) Whether the CI job should fail when a lint error is found. Only used when `run_lint` is set to `true`. Defaults to `true`.
 - `generate_docs` (Boolean) Flag for whether the job should generate documentation
 - `is_active` (Boolean) Should always be set to true as setting it to false is the same as creating a job in a deleted state. To create/keep a job in a 'deactivated' state, check  the `triggers` config.
-- `job_completion_trigger_condition` (Block Set, Max: 1) Which other job should trigger this job when it finishes, and on which conditions (sometimes referred as 'job chaining'). (see [below for nested schema](#nestedblock--job_completion_trigger_condition))
+- `job_completion_trigger_condition` (Block List) Which other job should trigger this job when it finishes, and on which conditions (sometimes referred as 'job chaining'). (see [below for nested schema](#nestedblock--job_completion_trigger_condition))
 - `job_type` (String) Can be used to enforce the job type betwen `ci`, `merge` and `scheduled`. Without this value the job type is inferred from the triggers configured
 - `num_threads` (Number) Number of threads to use in the job
 - `run_compare_changes` (Boolean) Whether the CI job should compare data changes introduced by the code changes. Requires `deferring_environment_id` to be set. (Advanced CI needs to be activated in the dbt Cloud Account Settings first as well)
@@ -137,12 +137,24 @@ resource "dbtcloud_job" "downstream_job" {
 - `schedule_type` (String) Type of schedule to use, one of every_day/ days_of_week/ custom_cron
 - `self_deferring` (Boolean) Whether this job defers on a previous run of itself
 - `target_name` (String) Target name for the dbt profile
-- `timeout_seconds` (Number) Number of seconds to allow the job to run before timing out
+- `timeout_seconds` (Number, Deprecated) [Deprectated - Moved to execution.timeout_seconds] Number of seconds to allow the job to run before timing out
 - `triggers_on_draft_pr` (Boolean) Whether the CI job should be automatically triggered on draft PRs
 
 ### Read-Only
 
-- `id` (String) The ID of this resource.
+- `id` (Number) The ID of this resource
+- `job_id` (Number) Job identifier
+
+<a id="nestedatt--triggers"></a>
+### Nested Schema for `triggers`
+
+Optional:
+
+- `git_provider_webhook` (Boolean) Whether the job runs automatically on PR creation
+- `github_webhook` (Boolean) Whether the job runs automatically on PR creation
+- `on_merge` (Boolean) Whether the job runs automatically once a PR is merged
+- `schedule` (Boolean) Whether the job runs on a schedule
+
 
 <a id="nestedblock--job_completion_trigger_condition"></a>
 ### Nested Schema for `job_completion_trigger_condition`

pkg/framework/objects/group/resource.go

@@ -59,7 +59,6 @@ func (r *groupResource) Read(
 		return
 	}
 
-	state.ID = types.Int64Value(int64(*retrievedGroup.ID))
 	state.ID = types.Int64Value(int64(*retrievedGroup.ID))
 	state.Name = types.StringValue(retrievedGroup.Name)
 	state.AssignByDefault = types.BoolValue(retrievedGroup.AssignByDefault)

pkg/framework/objects/job/model.go

@@ -48,7 +48,7 @@ type JobSchedule struct {
 
 type JobDataSourceModel struct {
 	Execution                     *JobExecution         `tfsdk:"execution"`
-	TimeoutSeconds                types.Int64         `tfsdk:"timeout_seconds"`
+	TimeoutSeconds                types.Int64           `tfsdk:"timeout_seconds"`
 	GenerateDocs                  types.Bool            `tfsdk:"generate_docs"`
 	RunGenerateSources            types.Bool            `tfsdk:"run_generate_sources"`
 	ID                            types.Int64           `tfsdk:"id"`
@@ -73,27 +73,64 @@ type JobDataSourceModel struct {
 
 // TODO remove this in the next major release
 type SingleJobDataSourceModel struct {
-	Execution                     *JobExecution                  `tfsdk:"execution"`
-	TimeoutSeconds                types.Int64                    `tfsdk:"timeout_seconds"`
-	GenerateDocs                  types.Bool                     `tfsdk:"generate_docs"`
-	RunGenerateSources            types.Bool                     `tfsdk:"run_generate_sources"`
-	ID                            types.Int64                    `tfsdk:"id"`
-	JobId                         types.Int64                    `tfsdk:"job_id"`
-	ProjectID                     types.Int64                    `tfsdk:"project_id"`
-	EnvironmentID                 types.Int64                    `tfsdk:"environment_id"`
-	Name                          types.String                   `tfsdk:"name"`
-	Description                   types.String                   `tfsdk:"description"`
-	DbtVersion                    types.String                   `tfsdk:"dbt_version"`
-	ExecuteSteps                  []types.String                 `tfsdk:"execute_steps"`
-	DeferringJobId                types.Int64                    `tfsdk:"deferring_job_id"`
-	DeferringEnvironmentID        types.Int64                    `tfsdk:"deferring_environment_id"`
-	SelfDeferring                 types.Bool                     `tfsdk:"self_deferring"`
-	Triggers                      *JobTriggers                   `tfsdk:"triggers"`
-	Settings                      *JobSettings                   `tfsdk:"settings"`
-	Schedule                      *JobSchedule                   `tfsdk:"schedule"`
-	JobType                       types.String                   `tfsdk:"job_type"`
-	TriggersOnDraftPr             types.Bool                     `tfsdk:"triggers_on_draft_pr"`
-	Environment                   *JobEnvironment                `tfsdk:"environment"`
+	Execution                     *JobExecution                    `tfsdk:"execution"`
+	TimeoutSeconds                types.Int64                      `tfsdk:"timeout_seconds"`
+	GenerateDocs                  types.Bool                       `tfsdk:"generate_docs"`
+	RunGenerateSources            types.Bool                       `tfsdk:"run_generate_sources"`
+	ID                            types.Int64                      `tfsdk:"id"`
+	JobId                         types.Int64                      `tfsdk:"job_id"`
+	ProjectID                     types.Int64                      `tfsdk:"project_id"`
+	EnvironmentID                 types.Int64                      `tfsdk:"environment_id"`
+	Name                          types.String                     `tfsdk:"name"`
+	Description                   types.String                     `tfsdk:"description"`
+	DbtVersion                    types.String                     `tfsdk:"dbt_version"`
+	ExecuteSteps                  []types.String                   `tfsdk:"execute_steps"`
+	DeferringJobId                types.Int64                      `tfsdk:"deferring_job_id"`
+	DeferringEnvironmentID        types.Int64                      `tfsdk:"deferring_environment_id"`
+	SelfDeferring                 types.Bool                       `tfsdk:"self_deferring"`
+	Triggers                      *JobTriggers                     `tfsdk:"triggers"`
+	Settings                      *JobSettings                     `tfsdk:"settings"`
+	Schedule                      *JobSchedule                     `tfsdk:"schedule"`
+	JobType                       types.String                     `tfsdk:"job_type"`
+	TriggersOnDraftPr             types.Bool                       `tfsdk:"triggers_on_draft_pr"`
+	Environment                   *JobEnvironment                  `tfsdk:"environment"`
 	JobCompletionTriggerCondition []*JobCompletionTriggerCondition `tfsdk:"job_completion_trigger_condition"`
-	RunCompareChanges             types.Bool                     `tfsdk:"run_compare_changes"`
+	RunCompareChanges             types.Bool                       `tfsdk:"run_compare_changes"`
+}
+
+type JobResourceModel struct {
+	// Execution                     *JobExecution         `tfsdk:"execution"`            // has timeout-seconds
+	TimeoutSeconds         types.Int64    `tfsdk:"timeout_seconds"`          // moved under execution , add deprecation message
+	GenerateDocs           types.Bool     `tfsdk:"generate_docs"`            // exists
+	RunGenerateSources     types.Bool     `tfsdk:"run_generate_sources"`     // exists
+	ID                     types.Int64    `tfsdk:"id"`                       // will hold job id?
+	JobId                  types.Int64    `tfsdk:"job_id"`                   // for framework
+	ProjectID              types.Int64    `tfsdk:"project_id"`               // exists
+	EnvironmentID          types.Int64    `tfsdk:"environment_id"`           // exists
+	Name                   types.String   `tfsdk:"name"`                     // exists
+	Description            types.String   `tfsdk:"description"`              // exists
+	DbtVersion             types.String   `tfsdk:"dbt_version"`              // exists
+	ExecuteSteps           []types.String `tfsdk:"execute_steps"`            // exists
+	DeferringEnvironmentID types.Int64    `tfsdk:"deferring_environment_id"` // exists
+	Triggers               *JobTriggers   `tfsdk:"triggers"`                 // exists
+	// Settings                      *JobSettings          `tfsdk:"settings"`                 // has no of threads and target name
+	// Schedule                      *JobSchedule          `tfsdk:"schedule"`                 // has cron expression
+	JobType           types.String `tfsdk:"job_type"`             // exists
+	TriggersOnDraftPr types.Bool   `tfsdk:"triggers_on_draft_pr"` // exists
+	// Environment                   *JobEnvironment       `tfsdk:"environment"`
+	JobCompletionTriggerCondition []*JobCompletionTriggerCondition `tfsdk:"job_completion_trigger_condition"` // exists
+	RunCompareChanges             types.Bool            `tfsdk:"run_compare_changes"`              // exists
+	IsActive                      types.Bool            `tfsdk:"is_active"`
+	TargetName                    types.String          `tfsdk:"target_name"` // add deprecated
+	NumThreads                    types.Int64           `tfsdk:"num_threads"` // add deprecated moved to settings
+	RunLint                       types.Bool            `tfsdk:"run_lint"`
+	ErrorsOnLintFailure           types.Bool            `tfsdk:"errors_on_lint_failure"`
+	ScheduleType                  types.String          `tfsdk:"schedule_type"`
+	ScheduleInterval              types.Int64           `tfsdk:"schedule_interval"`
+	ScheduleHours                 []types.Int64         `tfsdk:"schedule_hours"`
+	ScheduleDays                  []types.Int64         `tfsdk:"schedule_days"`
+	ScheduleCron                  types.String          `tfsdk:"schedule_cron"`    // add deprecated move to schedule
+	DeferringJobId                types.Int64           `tfsdk:"deferring_job_id"` // add deprecated move to deferring_job_definition_id
+	SelfDeferring                 types.Bool            `tfsdk:"self_deferring"`
+	CompareChangesFlags           types.String          `tfsdk:"compare_changes_flags"`
 }