Add conformance tests

Author: vladmld

pkg/framework/objects/databricks_credential/resource_acceptance_test.go

@@ -6,13 +6,49 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/dbt-labs/terraform-provider-dbtcloud/pkg/framework/acctest_config"
 	"github.com/dbt-labs/terraform-provider-dbtcloud/pkg/framework/acctest_helper"
 	"github.com/dbt-labs/terraform-provider-dbtcloud/pkg/helper"
 	"github.com/hashicorp/terraform-plugin-testing/helper/acctest"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/hashicorp/terraform-plugin-testing/terraform"
 )
 
+
+func TestConformanceBasicConfig(t *testing.T) {
+	projectName := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+	targetName := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+	token := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { acctest_helper.TestAccPreCheck(t) },
+		CheckDestroy: testAccCheckDbtCloudDatabricksCredentialDestroy,
+		Steps: []resource.TestStep{
+			acctest_helper.MakeExternalProviderTestStep(getBasicConfigTestStep(projectName, targetName, token), acctest_config.LAST_VERSION_BEFORE_FRAMEWORK_MIGRATION),
+			acctest_helper.MakeCurrentProviderNoOpTestStep(getBasicConfigTestStep(projectName, targetName, token)),
+		},
+	})
+}
+
+func TestConformanceModifyConfig(t *testing.T) {
+	projectName := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+	targetName := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+	targetName2 := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+	token := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+	token2 := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
+
+	// MODIFY: test that running commands in SDKv2 and then the same commands in Framework generates a NoOp plan
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { acctest_helper.TestAccPreCheck(t) },
+		CheckDestroy: testAccCheckDbtCloudDatabricksCredentialDestroy,
+		Steps: []resource.TestStep{
+			acctest_helper.MakeExternalProviderTestStep(getModifyConfigTestStep(projectName, targetName, targetName2, token, token2), acctest_config.LAST_VERSION_BEFORE_FRAMEWORK_MIGRATION),
+			acctest_helper.MakeCurrentProviderNoOpTestStep(getModifyConfigTestStep(projectName, targetName, targetName2, token, token2)),
+		},
+	})
+}
+
+
 func TestAccDbtCloudDatabricksCredentialResourceLegacy(t *testing.T) {
 
 	projectName := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
@@ -21,53 +57,16 @@ func TestAccDbtCloudDatabricksCredentialResourceLegacy(t *testing.T) {
 	token := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
 	token2 := strings.ToUpper(acctest.RandStringFromCharSet(10, acctest.CharSetAlpha))
 
+	var basicConfigTestStep = getBasicConfigTestStep(projectName, targetName, token)
+	var modifyConfigTestStep = getModifyConfigTestStep(projectName, targetName, targetName2, token, token2)
+	
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { acctest_helper.TestAccPreCheck(t) },
 		ProtoV6ProviderFactories: acctest_helper.TestAccProtoV6ProviderFactories,
 		CheckDestroy:             testAccCheckDbtCloudDatabricksCredentialDestroy,
 		Steps: []resource.TestStep{
-			{
-				Config: testAccDbtCloudDatabricksCredentialResourceBasicConfigLegacy(
-					projectName,
-					targetName,
-					token,
-				),
-				Check: resource.ComposeTestCheckFunc(
-					testAccCheckDbtCloudDatabricksCredentialExists(
-						"dbtcloud_databricks_credential.test_credential",
-					),
-					resource.TestCheckResourceAttr(
-						"dbtcloud_databricks_credential.test_credential",
-						"target_name",
-						targetName,
-					),
-				),
-			},
-			// RENAME
-			// MODIFY
-			{
-				Config: testAccDbtCloudDatabricksCredentialResourceBasicConfigLegacy(
-					projectName,
-					targetName2,
-					token2,
-				),
-				Check: resource.ComposeTestCheckFunc(
-					testAccCheckDbtCloudDatabricksCredentialExists(
-						"dbtcloud_databricks_credential.test_credential",
-					),
-					resource.TestCheckResourceAttr(
-						"dbtcloud_databricks_credential.test_credential",
-						"target_name",
-						targetName2,
-					),
-					resource.TestCheckResourceAttr(
-						"dbtcloud_databricks_credential.test_credential",
-						"token",
-						token2,
-					),
-				),
-			},
-			// IMPORT
+			basicConfigTestStep,
+			modifyConfigTestStep,	
 			{
 				ResourceName:            "dbtcloud_databricks_credential.test_credential",
 				ImportState:             true,
@@ -270,3 +269,49 @@ func testAccCheckDbtCloudDatabricksCredentialDestroy(s *terraform.State) error {
 
 	return nil
 }
+
+
+func getBasicConfigTestStep(projectName, targetName, token string) resource.TestStep {
+	return resource.TestStep{
+		Config: testAccDbtCloudDatabricksCredentialResourceBasicConfigLegacy(
+			projectName,
+			targetName,
+			token,
+		),
+		Check: resource.ComposeTestCheckFunc(
+			testAccCheckDbtCloudDatabricksCredentialExists(
+				"dbtcloud_databricks_credential.test_credential",
+			),
+			resource.TestCheckResourceAttr(
+				"dbtcloud_databricks_credential.test_credential",
+				"target_name",
+				targetName,
+			),
+		),
+	}
+}
+
+func getModifyConfigTestStep(projectName, targetName, targetName2, token, token2 string) resource.TestStep {
+	return resource.TestStep{
+		Config: testAccDbtCloudDatabricksCredentialResourceBasicConfigLegacy(
+			projectName,
+			targetName2,
+			token2,
+		),
+		Check: resource.ComposeTestCheckFunc(
+			testAccCheckDbtCloudDatabricksCredentialExists(
+				"dbtcloud_databricks_credential.test_credential",
+			),
+			resource.TestCheckResourceAttr(
+				"dbtcloud_databricks_credential.test_credential",
+				"target_name",
+				targetName2,
+			),
+			resource.TestCheckResourceAttr(
+				"dbtcloud_databricks_credential.test_credential",
+				"token",
+				token2,
+			),
+		),
+	}
+}