Skip to content

Commit ea679c5

Browse files
committed
docs(group): fix writable_environment_categories and clean up dbtcloud_group descriptions
Omitting writable_environment_categories grants no Write access — not Write access to all environments as the docs claimed. Use ["all"] to grant Write access everywhere. Same fix applied to group_partial_permissions, the two SCIM resources, and service_token. Also fixed copy-paste leftovers on dbtcloud_group: bad cross-reference to a non-existent partial resource, partial-permissions wording in the group_permissions block description, and a self-referential permission_set description.
1 parent 8385e22 commit ea679c5

13 files changed

Lines changed: 28 additions & 25 deletions

File tree

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
kind: Documentation
2+
body: Fixed `writable_environment_categories` description on group, partial permissions, SCIM and service token resources to reflect that omitting the value grants no Write access (use `["all"]` instead). Also cleaned up a few copy-paste doc strings on `dbtcloud_group`.
3+
time: 2026-05-08T18:28:33.548537+03:00

docs/data-sources/service_token.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,5 @@ Read-Only:
3737
- `writable_environment_categories` (Set of String) What types of environments to apply Write permissions to.
3838
Even if Write access is restricted to some environment types, the permission set will have Read access to all environments.
3939
The values allowed are `all`, `development`, `staging`, `production` and `other`.
40-
Not setting a value is the same as selecting `all`.
40+
Not setting a value (or setting an empty list) means the permission set has no Write access to any environment — only Read access. To grant Write access to all environments, set this to `["all"]`.
4141
Not all permission sets support environment level write settings, only `analyst`, `database_admin`, `developer`, `git_admin` and `team_admin`.

docs/resources/group.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
page_title: "dbtcloud_group Resource - dbtcloud"
33
subcategory: ""
44
description: |-
5-
Provide a complete set of permissions for a group. This is different from dbt_cloud_partial_group_permissions.
5+
Provide a complete set of permissions for a group. This is different from dbtcloud_group_partial_permissions.
66
With this resource type only one resource can be used to manage the permissions for a given group.
77
---
88

@@ -39,7 +39,7 @@ The mapping of permission names [from the docs](https://docs.getdbt.com/docs/clo
3939
|Webhooks Only | webhooks_only|
4040

4141

42-
Provide a complete set of permissions for a group. This is different from `dbt_cloud_partial_group_permissions`.
42+
Provide a complete set of permissions for a group. This is different from `dbtcloud_group_partial_permissions`.
4343

4444
With this resource type only one resource can be used to manage the permissions for a given group.
4545

@@ -71,7 +71,7 @@ resource "dbtcloud_group" "tf_group_1" {
7171
### Optional
7272

7373
- `assign_by_default` (Boolean) Whether the group will be assigned by default to users. The value needs to be the same for all partial permissions for the same group.
74-
- `group_permissions` (Block Set) Partial permissions for the group. Those permissions will be added/removed when config is added/removed. (see [below for nested schema](#nestedblock--group_permissions))
74+
- `group_permissions` (Block Set) The complete set of permissions to apply to the group. Each block defines one permission set; remove or modify blocks to adjust the group's permissions. (see [below for nested schema](#nestedblock--group_permissions))
7575
- `sso_mapping_groups` (Set of String) Mapping groups from the IdP. At the moment the complete list needs to be provided in each partial permission for the same group.
7676

7777
### Read-Only
@@ -84,15 +84,15 @@ resource "dbtcloud_group" "tf_group_1" {
8484
Required:
8585

8686
- `all_projects` (Boolean) Whether access should be provided for all projects or not.
87-
- `permission_set` (String) Set of permissions to apply. The permissions allowed are the same as the ones for the `dbtcloud_group` resource.
87+
- `permission_set` (String) The permission set to apply (e.g. `developer`, `analyst`, `account_admin`). See the table at the top of this page for the full list of permission codes.
8888

8989
Optional:
9090

9191
- `project_id` (Number) Project ID to apply this permission to for this group.
92-
- `writable_environment_categories` (Set of String) What types of environments to apply Write permissions to.
93-
Even if Write access is restricted to some environment types, the permission set will have Read access to all environments.
94-
The values allowed are `all`, `development`, `staging`, `production` and `other`.
95-
Not setting a value is the same as selecting `all`.
92+
- `writable_environment_categories` (Set of String) What types of environments to apply Write permissions to.
93+
Even if Write access is restricted to some environment types, the permission set will have Read access to all environments.
94+
The values allowed are `all`, `development`, `staging`, `production` and `other`.
95+
Not setting a value (or setting an empty list) means the permission set has no Write access to any environment — only Read access. To grant Write access to all environments, set this to `["all"]`.
9696
Not all permission sets support environment level write settings, only `analyst`, `database_admin`, `developer`, `git_admin` and `team_admin`.
9797

9898
## Import

docs/resources/group_partial_permissions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,5 +100,5 @@ Optional:
100100
- `writable_environment_categories` (Set of String) What types of environments to apply Write permissions to.
101101
Even if Write access is restricted to some environment types, the permission set will have Read access to all environments.
102102
The values allowed are `all`, `development`, `staging`, `production` and `other`.
103-
Not setting a value is the same as selecting `all`.
103+
Not setting a value (or setting an empty list) means the permission set has no Write access to any environment — only Read access. To grant Write access to all environments, set this to `["all"]`.
104104
Not all permission sets support environment level write settings, only `analyst`, `database_admin`, `developer`, `git_admin` and `team_admin`.

docs/resources/scim_group_partial_permissions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ Optional:
292292
- `writable_environment_categories` (Set of String) What types of environments to apply Write permissions to.
293293
Even if Write access is restricted to some environment types, the permission set will have Read access to all environments.
294294
The values allowed are `all`, `development`, `staging`, `production` and `other`.
295-
Not setting a value is the same as selecting `all`.
295+
Not setting a value (or setting an empty list) means the permission set has no Write access to any environment — only Read access. To grant Write access to all environments, set this to `["all"]`.
296296
Not all permission sets support environment level write settings, only `analyst`, `database_admin`, `developer`, `git_admin` and `team_admin`.
297297

298298
## Import

docs/resources/scim_group_permissions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,5 +63,5 @@ Optional:
6363
- `writable_environment_categories` (Set of String) What types of environments to apply Write permissions to.
6464
Even if Write access is restricted to some environment types, the permission set will have Read access to all environments.
6565
The values allowed are `all`, `development`, `staging`, `production` and `other`.
66-
Not setting a value is the same as selecting `all`.
66+
Not setting a value (or setting an empty list) means the permission set has no Write access to any environment — only Read access. To grant Write access to all environments, set this to `["all"]`.
6767
Not all permission sets support environment level write settings, only `analyst`, `database_admin`, `developer`, `git_admin` and `team_admin`.

docs/resources/service_token.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ Optional:
107107
- `writable_environment_categories` (Set of String) What types of environments to apply Write permissions to.
108108
Even if Write access is restricted to some environment types, the permission set will have Read access to all environments.
109109
The values allowed are `all`, `development`, `staging`, `production` and `other`.
110-
Not setting a value is the same as selecting `all`.
110+
Not setting a value (or setting an empty list) means the permission set has no Write access to any environment — only Read access. To grant Write access to all environments, set this to `["all"]`.
111111
Not all permission sets support environment level write settings, only `analyst`, `database_admin`, `developer`, `git_admin` and `team_admin`.
112112

113113
## Import

pkg/framework/objects/group/schema.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ func (r *groupResource) Schema(
2525
) {
2626
resp.Schema = resource_schema.Schema{
2727
Description: helper.DocString(
28-
`Provide a complete set of permissions for a group. This is different from ~~~dbt_cloud_partial_group_permissions~~~.
28+
`Provide a complete set of permissions for a group. This is different from ~~~dbtcloud_group_partial_permissions~~~.
2929
3030
With this resource type only one resource can be used to manage the permissions for a given group.
3131
`,
@@ -97,15 +97,15 @@ func (r *groupResource) Schema(
9797
// For now we use a Block to move from SDKv2 to PLugin Framework, but we might change to a SetAttribute in the future, using the code from above
9898
Blocks: map[string]resource_schema.Block{
9999
"group_permissions": resource_schema.SetNestedBlock{
100-
Description: "Partial permissions for the group. Those permissions will be added/removed when config is added/removed.",
100+
Description: "The complete set of permissions to apply to the group. Each block defines one permission set; remove or modify blocks to adjust the group's permissions.",
101101
NestedObject: resource_schema.NestedBlockObject{
102102
Attributes: map[string]resource_schema.Attribute{
103103
"permission_set": resource_schema.StringAttribute{
104104
Required: true,
105105
Validators: []validator.String{
106106
stringvalidator.OneOf(dbt_cloud.PermissionSets...),
107107
},
108-
Description: "Set of permissions to apply. The permissions allowed are the same as the ones for the `dbtcloud_group` resource.",
108+
Description: "The permission set to apply (e.g. `developer`, `analyst`, `account_admin`). See the table at the top of this page for the full list of permission codes.",
109109
},
110110
"project_id": resource_schema.Int64Attribute{
111111
Optional: true,
@@ -121,10 +121,10 @@ func (r *groupResource) Schema(
121121
Computed: true,
122122
Default: helper.EmptySetDefault(types.StringType),
123123
Description: helper.DocString(
124-
`What types of environments to apply Write permissions to.
125-
Even if Write access is restricted to some environment types, the permission set will have Read access to all environments.
126-
The values allowed are ~~~all~~~, ~~~development~~~, ~~~staging~~~, ~~~production~~~ and ~~~other~~~.
127-
Not setting a value is the same as selecting ~~~all~~~.
124+
`What types of environments to apply Write permissions to.
125+
Even if Write access is restricted to some environment types, the permission set will have Read access to all environments.
126+
The values allowed are ~~~all~~~, ~~~development~~~, ~~~staging~~~, ~~~production~~~ and ~~~other~~~.
127+
Not setting a value (or setting an empty list) means the permission set has no Write access to any environment — only Read access. To grant Write access to all environments, set this to ~~~["all"]~~~.
128128
Not all permission sets support environment level write settings, only ~~~analyst~~~, ~~~database_admin~~~, ~~~developer~~~, ~~~git_admin~~~ and ~~~team_admin~~~.`,
129129
),
130130
},

pkg/framework/objects/group_partial_permissions/schema.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ func (r *groupPartialPermissionsResource) Schema(
9898
`What types of environments to apply Write permissions to.
9999
Even if Write access is restricted to some environment types, the permission set will have Read access to all environments.
100100
The values allowed are ~~~all~~~, ~~~development~~~, ~~~staging~~~, ~~~production~~~ and ~~~other~~~.
101-
Not setting a value is the same as selecting ~~~all~~~.
101+
Not setting a value (or setting an empty list) means the permission set has no Write access to any environment — only Read access. To grant Write access to all environments, set this to ~~~["all"]~~~.
102102
Not all permission sets support environment level write settings, only ~~~analyst~~~, ~~~database_admin~~~, ~~~developer~~~, ~~~git_admin~~~ and ~~~team_admin~~~.`,
103103
),
104104
},

pkg/framework/objects/scim_group_partial_permissions/schema.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ func (r *scimGroupPartialPermissionsResource) Schema(
9292
`What types of environments to apply Write permissions to.
9393
Even if Write access is restricted to some environment types, the permission set will have Read access to all environments.
9494
The values allowed are ~~~all~~~, ~~~development~~~, ~~~staging~~~, ~~~production~~~ and ~~~other~~~.
95-
Not setting a value is the same as selecting ~~~all~~~.
95+
Not setting a value (or setting an empty list) means the permission set has no Write access to any environment — only Read access. To grant Write access to all environments, set this to ~~~["all"]~~~.
9696
Not all permission sets support environment level write settings, only ~~~analyst~~~, ~~~database_admin~~~, ~~~developer~~~, ~~~git_admin~~~ and ~~~team_admin~~~.`,
9797
),
9898
},

0 commit comments

Comments
 (0)