Skip to content

fix: remove connection_id default of 0 in dbtcloud_environment (closes #665) #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trouze wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: remove connection_id default of 0 in dbtcloud_environment (closes #665) #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f07a938
fix: remove connection_id default of 0 in dbtcloud_environment (close…
trouze Apr 9, 2026
523e932
chore: add changie entry for #665
trouze Apr 9, 2026
72f0147
fix: update test to expect null connection_id when not set
trouze Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changes/unreleased/Fixes-20260409-195804.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: Fixes
body: Remove `connection_id` default of `0` in `dbtcloud_environment` to prevent "inconsistent result after apply" when the API auto-assigns a connection
time: 2026-04-09T19:58:04.000000+00:00
31 changes: 14 additions & 17 deletions pkg/framework/objects/environment/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ var (
_ resource.ResourceWithImportState = &environmentResource{}
)

// connectionIDFromAPI converts the API connection_id pointer to a types.Int64 value,
// treating nil and 0 as "not set" (null) so Terraform doesn't see a spurious diff.
func connectionIDFromAPI(id *int) types.Int64 {
if id != nil && *id != 0 {
return types.Int64Value(int64(*id))
}
return types.Int64Null()
}

func EnvironmentResource() resource.Resource {
return &environmentResource{}
}
Expand Down Expand Up @@ -81,11 +90,7 @@ func (r *environmentResource) Read(
state.ExtendedAttributesID = types.Int64Null()
}
state.EnableModelQueryHistory = types.BoolValue(environment.EnableModelQueryHistory)
if environment.ConnectionID != nil {
state.ConnectionID = types.Int64Value(int64(*environment.ConnectionID))
} else {
state.ConnectionID = types.Int64Value(0)
}
state.ConnectionID = connectionIDFromAPI(environment.ConnectionID)
if environment.Credential_Id != nil {
state.CredentialID = types.Int64Value(int64(*environment.Credential_Id))
} else {
Expand Down Expand Up @@ -185,11 +190,7 @@ func (r *environmentResource) Create(
plan.ExtendedAttributesID = types.Int64Null()
}
plan.EnableModelQueryHistory = types.BoolValue(environment.EnableModelQueryHistory)
if environment.ConnectionID != nil {
plan.ConnectionID = types.Int64Value(int64(*environment.ConnectionID))
} else {
plan.ConnectionID = types.Int64Value(0)
}
plan.ConnectionID = connectionIDFromAPI(environment.ConnectionID)
plan.CredentialID = types.Int64PointerValue(
helper.IntPointerToInt64Pointer(environment.Credential_Id),
)
Expand Down Expand Up @@ -329,11 +330,7 @@ func (r *environmentResource) Update(
}

plan.EnvironmentID = types.Int64Value(int64(*updatedEnv.Environment_Id))
if updatedEnv.ConnectionID != nil {
plan.ConnectionID = types.Int64Value(int64(*updatedEnv.ConnectionID))
} else {
plan.ConnectionID = types.Int64Value(0)
}
plan.ConnectionID = connectionIDFromAPI(updatedEnv.ConnectionID)
if updatedEnv.Credential_Id != nil {
plan.CredentialID = types.Int64Value(int64(*updatedEnv.Credential_Id))
} else {
Expand Down Expand Up @@ -435,8 +432,8 @@ func (r *environmentResource) ImportState(
return
}

// Set connection_id to 0 to match the test's expectation
resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("connection_id"), types.Int64Value(0))...)
// Set connection_id to null so it is refreshed from the API on the next plan/apply
resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("connection_id"), types.Int64Null())...)
}

func (r *environmentResource) Configure(
Expand Down
3 changes: 1 addition & 2 deletions pkg/framework/objects/environment/resource_acceptance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,9 @@ func getBasicConfigWithModifiedConfigTestStep(projectName, environmentName, cust
"deployment_type",
"production",
),
resource.TestCheckResourceAttr(
resource.TestCheckNoResourceAttr(
"dbtcloud_environment.test_env",
"connection_id",
"0",
),
),
}
Expand Down
2 changes: 0 additions & 2 deletions pkg/framework/objects/environment/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
"github.com/hashicorp/terraform-plugin-framework/resource"
resource_schema "github.com/hashicorp/terraform-plugin-framework/resource/schema"
"github.com/hashicorp/terraform-plugin-framework/resource/schema/booldefault"
"github.com/hashicorp/terraform-plugin-framework/resource/schema/int64default"
"github.com/hashicorp/terraform-plugin-framework/resource/schema/int64planmodifier"
"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringdefault"
Expand Down Expand Up @@ -263,7 +262,6 @@ func (r *environmentResource) Schema(
"connection_id": resource_schema.Int64Attribute{
Optional: true,
Computed: true,
Default: int64default.StaticInt64(0),
Description: "A connection ID (used with Global Connections)",
PlanModifiers: []planmodifier.Int64{
int64planmodifier.UseStateForUnknown(),
Expand Down
Loading