feat(group): support notification_manager permission_set (#692)#693
Open
will-sargent-dbtlabs wants to merge 1 commit into
Open
feat(group): support notification_manager permission_set (#692)#693will-sargent-dbtlabs wants to merge 1 commit into
will-sargent-dbtlabs wants to merge 1 commit into
Conversation
Add `notification_manager` to the allowed `permission_set` values for `dbtcloud_group`, `dbtcloud_group_partial_permissions`, `dbtcloud_scim_group_permissions`, `dbtcloud_scim_group_partial_permissions`, and `dbtcloud_service_token`. The dbt Cloud backend added this permission set in dbt-cloud#17425. The provider was rejecting it at validation time, blocking IaC management of the permission that is already configurable via the UI. Resolves #692. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notification_managerto the allowedpermission_setvalues, so it can be assigned viadbtcloud_group,dbtcloud_group_partial_permissions,dbtcloud_scim_group_permissions,dbtcloud_scim_group_partial_permissions, anddbtcloud_service_tokendbtcloud_groupanddbtcloud_service_tokendocs (templates + regenerateddocs/).changes/unreleasedWhy
The dbt Cloud backend added the
notification_managerpermission set in dbt-cloud#17425. The provider was rejecting it at validation time, blocking IaC management of a permission that is already configurable via the UI (Enterprise Settings → Groups & Licence → Permission set). Reported in #692.Test plan
go build ./...go test ./pkg/dbt_cloud/... ./pkg/framework/objects/group/... ./pkg/framework/objects/service_token/... ./pkg/framework/objects/group_partial_permissions/... ./pkg/framework/objects/scim_group_permissions/... ./pkg/framework/objects/scim_group_partial_permissions/...go generate ./...— confirmed only the two expected doc files changeddbtcloud_groupwithpermission_set = "notification_manager"against a dbt Cloud account that has the permission enabledResolves #692.
🤖 Generated with Claude Code