Skip to content

Commit 398589e

Browse files
committed
Preparing for v0.3
- Bumping PHP requirement to 5.6 - Adding some additional logging points - Adding additional logging methods
1 parent 61f5d68 commit 398589e

File tree

6 files changed

+82
-11
lines changed

6 files changed

+82
-11
lines changed

composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
],
1818

1919
"require": {
20-
"php": ">=5.4.0",
20+
"php": ">=5.6.0",
2121
"dcarbone/curl-header-extractor": "2.0.*"
2222
},
2323

src/AbstractApiClient.php

+6-2
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,17 @@ protected function requireOK(array $requestResult)
4949

5050
if (200 !== $requestResult[1]->httpCode)
5151
{
52-
return [$requestResult[0], $requestResult[1], new Error(sprintf(
52+
$err = new Error(sprintf(
5353
'%s - Error seen while executing "%s". Response code: %d. Message: %s',
5454
get_class($this),
5555
$requestResult[1]->url,
5656
$requestResult[1]->httpCode,
5757
$requestResult[1]->curlError
58-
))];
58+
));
59+
60+
Logger::error($err);
61+
62+
return [$requestResult[0], $requestResult[1], $err];
5963
}
6064

6165
return $requestResult;

src/DateTime.php

+7
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,13 @@
2222
*/
2323
class DateTime extends \DateTime implements \JsonSerializable
2424
{
25+
const Nanosecond = 1;
26+
const Microsecond = 1000 * self::Nanosecond;
27+
const Millisecond = 1000 * self::Microsecond;
28+
const Second = 1000 * self::Millisecond;
29+
const Minute = 60 * self::Second;
30+
const Hour = 60 * self::Minute;
31+
2532
/** @var string */
2633
private static $_defaultFormat = 'Y-m-d\TH:i:s.uO';
2734

src/Error.php

+16
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,22 @@ public function __construct($message)
4040
$this->_message = $message;
4141
}
4242

43+
/**
44+
* @return DateTime
45+
*/
46+
public function getTimestamp()
47+
{
48+
return $this->_timestamp;
49+
}
50+
51+
/**
52+
* @return string
53+
*/
54+
public function getMessage()
55+
{
56+
return $this->_message;
57+
}
58+
4359
/**
4460
* Specify data which should be serialized to JSON
4561
* @link http://php.net/manual/en/jsonserializable.jsonserialize.php

src/HttpRequest.php

+3-4
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ public function execute()
150150
);
151151
}
152152

153-
Logger::log('debug', 'Executing '.$this->method.' request '.$this->url.($this->body ? ' with body "'.$this->body.'"':''));
153+
Logger::debug('Executing '.$this->method.' request '.$this->url.($this->body ? ' with body "'.$this->body.'"':''));
154154

155155
switch($this->method)
156156
{
@@ -192,16 +192,15 @@ public function execute()
192192
get_class($this),
193193
json_encode($this->_curlOpts)
194194
));
195-
Logger::log('error', $err);
195+
Logger::error($err);
196196
return [null, $err];
197197
}
198198

199199
$response = new HttpResponse(curl_exec($ch), curl_getinfo($ch), curl_error($ch));
200200

201201
curl_close($ch);
202202

203-
204-
Logger::log('debug', 'Response received - Code: '.$response->httpCode.'; Body: '.$response->body.'; ');
203+
Logger::debug('Response received - Code: '.$response->httpCode.'; Body: '.$response->body.'; ');
205204

206205
return [$response, null];
207206
}

src/Logger.php

+49-4
Original file line numberDiff line numberDiff line change
@@ -116,14 +116,27 @@ public static function resetLoggers()
116116
}
117117

118118
/**
119-
* @param string $logLevel
119+
* @param string $level
120120
* @param string $message
121121
*/
122-
public static function log($logLevel, $message)
122+
public static function log($level, $message)
123123
{
124-
$level = strtolower($logLevel);
125-
if (self::$_logLevels[self::$_logLevel] <= self::$_logLevels[strtolower($level)])
124+
if (!is_string($level) || !isset(self::$_logLevels[$level]))
125+
{
126+
trigger_error(sprintf(
127+
'%s::log - Specified level "%s" is not valid. Available levels are: ["%s"]',
128+
get_called_class(),
129+
is_string($level) ? $level : gettype($level),
130+
implode('","', array_keys(self::$_logLevels))
131+
));
132+
return;
133+
}
134+
135+
if (self::$_logLevels[self::$_logLevel] <= self::$_logLevels[$level])
126136
{
137+
if ($message instanceof Error)
138+
$message = $message->getMessage();
139+
127140
if (self::$_defaultLogger)
128141
self::$_defaultLogger->{$level}($message);
129142

@@ -133,5 +146,37 @@ public static function log($logLevel, $message)
133146
}
134147
}
135148
}
149+
150+
/**
151+
* @param string $message
152+
*/
153+
public static function error($message)
154+
{
155+
self::log('error', $message);
156+
}
157+
158+
/**
159+
* @param string $message
160+
*/
161+
public static function warn($message)
162+
{
163+
self::log('warn', $message);
164+
}
165+
166+
/**
167+
* @param string $message
168+
*/
169+
public static function info($message)
170+
{
171+
self::log('info', $message);
172+
}
173+
174+
/**
175+
* @param string $message
176+
*/
177+
public static function debug($message)
178+
{
179+
self::log('debug', $message);
180+
}
136181
}
137182
Logger::init();

0 commit comments

Comments
 (0)