fix(h5): 修复 getSystemInfoSync API windowTop 计算错误的问题 (question/220141)#6004
Open
chouchouji wants to merge 1 commit into
Open
fix(h5): 修复 getSystemInfoSync API windowTop 计算错误的问题 (question/220141)#6004chouchouji wants to merge 1 commit into
chouchouji wants to merge 1 commit into
Conversation
chouchouji
force-pushed
the
fix-ask-issue-220141
branch
from
3571a79 to
7209b41
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect windowTop calculation in the H5 implementation of getSystemInfoSync/getWindowInfo by accounting for the top-window layout offset (--top-window-height) in addition to the existing window top offset (--window-top + safe area).
Changes:
- Update
getWindowInfoto computewindowTopastop + topWindowHeightfromgetWindowOffset(). - Ensure
windowHeightis reduced by the correctedwindowTop, improving downstream size/layout calculations derived from system/window info.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.