Bring back code comments

ddelange · ddelange · commit 707d63051195 · 2025-04-28T18:38:19.000+03:00
diff --git a/storages/backends/s3.py b/storages/backends/s3.py
@@ -331,6 +331,9 @@ def __init__(self, **settings):
                 "AWS_S3_SECRET_ACCESS_KEY/secret_key"
             )
 
+        # These variables are used for a boto3 client time-to-live caching mechanism.
+        # We want to avoid storing a resource for too long to avoid their memory leak
+        # ref https://github.com/boto/boto3/issues/1670.
         self._connection_lock = threading.Lock()
         self._connection_expiry = None
         self._connection = None

Original file line number	Diff line number	Diff line change
`@@ -331,6 +331,9 @@ def __init__(self, **settings):`
`331`	`331`	`"AWS_S3_SECRET_ACCESS_KEY/secret_key"`
`332`	`332`	`)`
`333`	`333`
	`334`	`+ # These variables are used for a boto3 client time-to-live caching mechanism.`
	`335`	`+ # We want to avoid storing a resource for too long to avoid their memory leak`
	`336`	`+ # ref https://github.com/boto/boto3/issues/1670.`
`334`	`337`	`self._connection_lock = threading.Lock()`
`335`	`338`	`self._connection_expiry = None`
`336`	`339`	`self._connection = None`